public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@redhat.com>,
	Ron van der Wees <rvdwees@redhat.com>,
	Erik Mouw <erik.mouw_2@nxp.com>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	walken@google.com, Shaohua Li <shli@kernel.org>,
	Mel Gorman <mgorman@suse.de>
Subject: Re: [RFC PATCH v2 -mm] provide estimated available memory in /proc/meminfo
Date: Thu, 7 Nov 2013 14:27:40 -0800	[thread overview]
Message-ID: <20131107142740.3cb3679dd778b501d27c2f73@linux-foundation.org> (raw)
In-Reply-To: <20131107212132.GA1092@cmpxchg.org>

On Thu, 7 Nov 2013 16:21:32 -0500 Johannes Weiner <hannes@cmpxchg.org> wrote:

> > Subject: provide estimated available memory in /proc/meminfo
> > 
> > Many load balancing and workload placing programs check /proc/meminfo
> > to estimate how much free memory is available. They generally do this
> > by adding up "free" and "cached", which was fine ten years ago, but
> > is pretty much guaranteed to be wrong today.
> > 
> > It is wrong because Cached includes memory that is not freeable as
> > page cache, for example shared memory segments, tmpfs, and ramfs,
> > and it does not include reclaimable slab memory, which can take up
> > a large fraction of system memory on mostly idle systems with lots
> > of files.
> > 
> > Currently, the amount of memory that is available for a new workload,
> > without pushing the system into swap, can be estimated from MemFree,
> > Active(file), Inactive(file), and SReclaimable, as well as the "low"
> > watermarks from /proc/zoneinfo.
> > 
> > However, this may change in the future, and user space really should
> > not be expected to know kernel internals to come up with an estimate
> > for the amount of free memory.
> > 
> > It is more convenient to provide such an estimate in /proc/meminfo.
> > If things change in the future, we only have to change it in one place.
> > 
> > Signed-off-by: Rik van Riel <riel@redhat.com>
> > Reported-by: Erik Mouw <erik.mouw_2@nxp.com>
> 
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> 
> I have a suspicion that people will end up relying on this number to
> start new workloads in situations where lots of the page cache is
> actually heavily used.  We might not swap, but there will still be IO
> from thrashing cache.
> 
> Maybe we'll have to subtract mapped cache pages in the future to
> mitigate this risk somehow...
> 
> Anyway, we can defer this to when it's proven to be an actual problem.

Well not really.  Once we release this thing with a particular
implementation, we are constrained in making any later changes.  If we
change it to produce larger numbers, someone's workload will start
swapping.  If we change it to produce smaller numbers, someone's
workload will refuse to start.

It all needs a bit of thought, and even some testing!  I labelled this
one for-3.14.

  reply	other threads:[~2013-11-07 22:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ECFC0369-0745-44AB-9858-E689F41CCB4D@nxp.com>
     [not found] ` <5256D4C7.90301@redhat.com>
     [not found]   ` <DB649DE8-5595-4370-912B-BDC6BD5FF8C3@nxp.com>
     [not found]     ` <20131025120752.GB2415@rh0004426.ams.redhat.com>
2013-11-05 22:38       ` [RFC PATCH -mm] provide estimated available memory in /proc/meminfo Rik van Riel
2013-11-05 22:39         ` Kirill A. Shutemov
2013-11-05 22:45         ` Andrew Morton
2013-11-07 15:13           ` [RFC PATCH v2 " Rik van Riel
2013-11-07 21:21             ` Johannes Weiner
2013-11-07 22:27               ` Andrew Morton [this message]
2013-11-08  0:27               ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131107142740.3cb3679dd778b501d27c2f73@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=erik.mouw_2@nxp.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=rvdwees@redhat.com \
    --cc=shli@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox