From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
David Long <dave.long@linaro.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] uprobes: preparations for arm port
Date: Thu, 7 Nov 2013 17:27:36 +0100 [thread overview]
Message-ID: <20131107162736.GA31834@redhat.com> (raw)
In-Reply-To: <20131107151601.GA5163@gmail.com>
On 11/07, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@redhat.com> wrote:
>
> > and we need to cleanup copy_insn()
> > first.
Heh. I never read it carefully, I always knew it should be cleanuped.
But when I looked at it now I realized that it is very wrong, and it
is very easy to crash the kernel (fortunately only root can enable
uprobes).
So we need to fix it (and cleanup), I'll try to make the patch asap.
> > For the moment, please ignore the patch which adds the new ->ixol
> > member.
>
> I didn't actually disagree with it so I pulled it
Thanks,
> - I was just wondering
> about those cleanliness details.
And you are right, this doesn't look clean. I should have mentioned
in the changelog that we need to (at least try) to cleanup this all.
Oleg.
next prev parent reply other threads:[~2013-11-07 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 19:19 [GIT PULL] uprobes: preparations for arm port Oleg Nesterov
2013-11-07 5:36 ` Srikar Dronamraju
2013-11-07 7:48 ` Ingo Molnar
2013-11-07 7:51 ` Ingo Molnar
2013-11-07 14:34 ` Oleg Nesterov
2013-11-07 15:16 ` Ingo Molnar
2013-11-07 16:27 ` Oleg Nesterov [this message]
2013-11-07 19:40 ` [PATCH 0/1] uprobes: Fix the memory out of bound overwrite in copy_insn() Oleg Nesterov
2013-11-07 19:40 ` [PATCH 1/1] " Oleg Nesterov
2013-11-08 16:24 ` Oleg Nesterov
2013-11-13 10:38 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107162736.GA31834@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dave.long@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox