Re: [dm-devel] [PATCH 4/9] block: Make generic_make_request handle arbitrary sized bios

Kent Overstreet
2013-11-05T00:55:36Z

On Mon, Nov 04, 2013 at 03:56:52PM -0800, Mike Christie wrote:
> On 11/04/2013 03:36 PM, Kent Overstreet wrote:
> > @@ -1822,6 +1820,14 @@ void generic_make_request(struct bio *bio)
> > */
> > blk_queue_bounce(q, &bio);
> >
> > + if (!blk_queue_largebios(q))
> > + split = blk_bio_segment_split(q, bio, q->bio_split);
>
>
> Is it assumed bios coming down this path are created using bio_add_page?
> If not, does blk_bio_segment_split need a queue_max_sectors or
> queue_max_hw_sectors check? I only saw a segment count check below.

Shoot, you're absolutely right - thanks, I'll have this fixed in the next
version.