From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756879Ab3KHJMW (ORCPT ); Fri, 8 Nov 2013 04:12:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:28109 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752822Ab3KHJMQ (ORCPT ); Fri, 8 Nov 2013 04:12:16 -0500 USER-AGENT: Mutt/1.5.21 (2010-09-15) MIME-Version: 1.0 Message-ID: <20131108084136.GY26669@mwanda> Date: Fri, 8 Nov 2013 00:41:36 -0800 (PST) From: Dan Carpenter To: Mugunthan V N Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] net: make ndev->irq signed for error handling References: <20131107074849.GF21844@elgon.mountain> <527B842E.2060909@ti.com> <20131107122249.GN20521@mwanda> <527BC0CF.70003@ti.com> In-Reply-To: <527BC0CF.70003@ti.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote: > On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: > > On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: > >> On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: > >>> There is a bug in cpsw_probe() where we do: > >>> > >>> ndev->irq = platform_get_irq(pdev, 0); > >>> if (ndev->irq < 0) { > >>> > >>> The problem is that "ndev->irq" is unsigned so the error handling > >>> doesn't work. I have changed it to a regular int. > >>> > >>> Signed-off-by: Dan Carpenter > >> ndev->irq is never used any where in the driver, I think its better to > >> remove this part of code from probe. If every one is ok, I can send a > >> patch to remove the code. > > It seems like cpsw_ndo_poll_controller() uses it. > > > > > > That can be changed to pass one of the interrupt numbers from priv as > the irq number is not used in interrupt service routine. I don't know anything about this driver, so I'm fine with your idea. regards, dan carpenter