From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757005Ab3KHJNw (ORCPT ); Fri, 8 Nov 2013 04:13:52 -0500 Received: from top.free-electrons.com ([176.31.233.9]:56072 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756971Ab3KHJNq (ORCPT ); Fri, 8 Nov 2013 04:13:46 -0500 Date: Fri, 8 Nov 2013 06:13:47 -0300 From: Ezequiel Garcia To: Caizhiyong Cc: Andrew Morton , Brian Norris , "Wanglin (Albert)" , Artem Bityutskiy , "linux-kernel@vger.kernel.org" , Karel Zak , "linux-mtd@lists.infradead.org" , Shmulik Ladkani Subject: Re: [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib Message-ID: <20131108091216.GA2365@localhost> References: <20131020120603.GA18678@localhost> <20131105144328.fb5a6a1d423776b324771706@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 08, 2013 at 06:53:29AM +0000, Caizhiyong wrote: > >> For further information, see "https://lkml.org/lkml/2013/8/6/550" > > > > Thanks for doing this. Could we please get some acked-by's or, > > preferably, tested-by's from the MTD people? > > Acked-by: Ezequiel Garcia I don't remember acking this patch! Instead, I do remember asking for the test results, prooving the this change has _no_ change of behavior compared to the MTD parsing code: https://lkml.org/lkml/2013/10/25/164 Such results was never posted and unless we see those, I think I'd rather NACK this patch instead. I like the cleanup, but only if it's guaranteed to _not_ brake things, specially when dealing with a kernel parameter. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com