linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jan Kara <jack@suse.cz>, Frederic Weisbecker <fweisbec@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu
Date: Fri, 8 Nov 2013 11:18:01 +0100	[thread overview]
Message-ID: <20131108101801.GA6343@quack.suse.cz> (raw)
In-Reply-To: <20131107183142.4ae4345e@gandalf.local.home>

On Thu 07-11-13 18:31:42, Steven Rostedt wrote:
> On Fri, 8 Nov 2013 00:01:11 +0100
> Jan Kara <jack@suse.cz> wrote:
> 
> > On Thu 07-11-13 23:54:10, Frederic Weisbecker wrote:
> 
> > > So if the current CPU can handle it, what is the problem?
> >   I hope this gets cleared out in my other email. But to make sure: If
> > other CPUs are idle (i.e. not appending to the printk buffer), we can well
> > handle the printing on the current CPU (with some breaks to allow
> > interrupts to be served etc.). If other CPUs are also appending to printk
> > buffer, that's where we really want to push the work to other CPUs.
> 
> I guess the question is, how does it migrate? I guess that's not so
> clear. Or do you just hope that the timer tick on another CPU will come
> in first and finish the job for you? As the list is global and all CPUs
> get to see it.
  There are two possibilities how the migration can happen:
1) a tick happens first on some other cpu and thus it will pick up the work
2) a printk happens first on some other cpu and thus it will pick printing
   in its console_unlock() call.

  I agree in both cases we depend on statistics, there's no real guarantee
the migration happens. But in my testing this seems to be enough.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2013-11-08 10:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 21:48 [PATCH 0/4 v6] Avoid softlockups in console_unlock() Jan Kara
2013-11-07 21:48 ` [PATCH 1/4] printk: Remove separate printk_sched buffers and use printk buf instead Jan Kara
2013-11-07 21:48 ` [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu Jan Kara
2013-11-07 22:13   ` Frederic Weisbecker
2013-11-07 22:19     ` Jan Kara
2013-11-07 22:23       ` Frederic Weisbecker
2013-11-07 22:50         ` Jan Kara
2013-11-07 22:54           ` Frederic Weisbecker
2013-11-07 23:01             ` Jan Kara
2013-11-07 23:31               ` Steven Rostedt
2013-11-08 10:18                 ` Jan Kara [this message]
2013-11-07 22:32       ` Frederic Weisbecker
2013-11-07 21:48 ` [PATCH 3/4] printk: Defer printing to irq work when we printed too much Jan Kara
2013-11-07 22:43   ` Frederic Weisbecker
2013-11-07 22:57     ` Jan Kara
2013-11-07 23:21       ` Frederic Weisbecker
2013-11-07 23:37         ` Steven Rostedt
2013-11-07 23:44           ` Frederic Weisbecker
2013-11-07 23:46           ` Frederic Weisbecker
2013-11-08 10:21             ` Jan Kara
2013-11-22 23:27               ` Andrew Morton
2013-11-25 12:08                 ` Jan Kara
2013-11-11 21:54       ` Pavel Machek
2013-11-11 22:17         ` Jan Kara
2013-11-16 11:35           ` Pavel Machek
2013-11-07 22:59     ` Steven Rostedt
2013-11-07 21:48 ` [PATCH 4/4] printk: Use unbound irq work for printing and waking Jan Kara
  -- strict thread matches above, loose matches on Subject: below --
2013-08-21  8:08 [PATCH 0/4 v6] Avoid softlockups in console_unlock() Jan Kara
2013-08-21  8:08 ` [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu Jan Kara
2013-08-21 18:49   ` Steven Rostedt
2013-09-05 15:56     ` Jan Kara
2013-08-14 13:28 [PATCH 0/4 v5] Avoid softlockups in console_unlock() Jan Kara
2013-08-14 13:28 ` [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131108101801.GA6343@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).