From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758025Ab3KHSY1 (ORCPT ); Fri, 8 Nov 2013 13:24:27 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:33227 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757899Ab3KHSYZ (ORCPT ); Fri, 8 Nov 2013 13:24:25 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 108.39.110.144 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/+ESlJIwFyBQ6G5KV4VMbTxLBR4GSnEzc= Date: Fri, 8 Nov 2013 13:24:15 -0500 From: Jason Cooper To: Kumar Gala Cc: Sebastian Hesselbarth , Olof Johansson , Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Stephen Warren , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Rob Landley , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 7/9] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Message-ID: <20131108182415.GG10335@titan.lakedaemon.net> References: <1381235073-17134-1-git-send-email-sebastian.hesselbarth@gmail.com> <1383661723-17956-1-git-send-email-sebastian.hesselbarth@gmail.com> <1383661723-17956-8-git-send-email-sebastian.hesselbarth@gmail.com> <0AF697FD-60AA-4B8B-A35F-3DF2FFBCF7AF@codeaurora.org> <20131108165721.GA10335@titan.lakedaemon.net> <8DC09031-553C-4FD5-8F05-F93D6FE40F3A@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8DC09031-553C-4FD5-8F05-F93D6FE40F3A@codeaurora.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 08, 2013 at 12:06:26PM -0600, Kumar Gala wrote: > > On Nov 8, 2013, at 10:57 AM, Jason Cooper wrote: > > > On Fri, Nov 08, 2013 at 10:13:19AM -0600, Kumar Gala wrote: > >> On Nov 5, 2013, at 8:28 AM, Sebastian Hesselbarth wrote: > > ... > >>> .../devicetree/bindings/arm/marvell,berlin.txt | 24 +++ > >>> arch/arm/boot/dts/Makefile | 2 + > >>> arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts | 29 +++ > >>> arch/arm/boot/dts/berlin2.dtsi | 227 ++++++++++++++++++++ > >>> 4 files changed, 282 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/arm/marvell,berlin.txt > >>> create mode 100644 arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts > >>> create mode 100644 arch/arm/boot/dts/berlin2.dtsi > >> > >> Haven't we been trying to go away from non-prefixed dts/dtsi? > > > > hmmm, this is the first I've heard of that. Although, your proposal > > (in another thread) makes more sense now. :) > > > >> So should these be something like marvell-berlin2-... > > > > I don't recall this being brought up at the summit, nor in Grant's > > report. I do need to give it a more careful read this weekend, though. > > Perhaps I missed something. > > This was based on review comments Olof gave when we pushed some .dts > files for MSM/APQ Qualcomm Technologies soc/boards. As Andrew Lunn mentioned to me earlier, we should consider the fact that the dts file names are being used by Debian's flash-kernel. Oh no! Another ABI! ;-) Personally, I think dtc should be using the board compatible string, and naming the resultant dtbs the same, eg $ dtc kirkwood-dreamplug.dts globalscale,dreamplug-003-ds2001.dtb This would free us up to rename the dts files as needed. dtb filenames would be guaranteed unique and consistent. It would also allow us to catch inadvertent compatible string collisions earlier. thx, Jason.