Re: [PATCH] clk: add flags to distinguish xtal clocks

Luca Coelho
2013-11-12T08:06:34Z

On Mon, 2013-11-11 at 21:59 +0100, Maxime Ripard wrote:
> Hi Luca,
>
> On Mon, Nov 11, 2013 at 09:50:56PM +0200, Luca Coelho wrote:
> > On Mon, 2013-11-11 at 13:42 -0600, Felipe Balbi wrote:
> > > > > + if (of_property_read_bool(node, "clock-xtal"))
> > > > > + flags |= CLK_IS_TYPE_XTAL;
> > > > > +
> > > >
> > > > Introducing a new compatible instead of a property would make more
> > > > sense here I think.
> > > >
> > > > Do you have a reason not to do so?
> > >
> > > As you can see, this is original work from Luca but I disagree that
> > > adding a new compatible makes more sense. This still related to a fixed
> > > rate clock, we're just giving it one extra metadata which willAnd t
> > > differentiate between crystal and oscilator fixed rate clocks.
> >
> > I agree with Felipe. This was discussed before [1]. While still at TI,
> > I tried to figure out the exact need for the firmware to know whether it
> > was an oscillator or not. It was mostly because the stabilization time
> > and such things differ with oscillators, but I wasn't able to find out
> > how exactly this affected things.
> >
> > In any case, as I concluded earlier (but it's not really my call), being
> > a crystal or an oscillator *is* a characteristic of the hardware,
> > regardless of whether that information is useful or not. In the WiLink
> > case it is, at least it can differentiate the clocks that are used in
> > the HW modules it uses.
> >
> > So IMHO it doesn't really hurt and it's not really against the DT
> > principles.
>
> Just to be clear, I'm not against your patch. If you need this to make
> your driver work, then it's fine for me. Mike will probably know
> better if we actually need some extra metadata.

:)

I understand, we should really try to make this as clean as possible, DT
should really be a good description of the hardware.

> What I'm not really convinced about is *how* you carry that metadata
> in the DT, that's all, nothing more.

Okay, I get you. My point is that being a crystal or not *is* a
characteristic of the clock, so I think it could be part of the flags
that describe it.

In any case, it's not really my call. This is about the clock and it's
not even my home turf (wireless). ;)

Thanks for your comments. And I'm sorry if the tone of my previous
email sounded harsh, it was not supposed to. :)

--
Cheers,
Luca.