From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] extcon: arizona: Eliminate dead error handling code
Date: Mon, 11 Nov 2013 09:22:54 +0000 [thread overview]
Message-ID: <20131111092254.GC6549@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20131111090014.GB30901@lee--X1>
On Mon, Nov 11, 2013 at 09:00:14AM +0000, Lee Jones wrote:
> > As a small disclaimer I would personally prefer to not merge this patch.
> > I have added it based on previous code review of the other patches in
> > this chain.
>
> I'd prefer the functionally redundant 'else if' over the comment.
>
> I'm happy not to merge this patch.
I agree entirely the redundant 'else if' is much better.
Thanks,
Charles
next prev parent reply other threads:[~2013-11-11 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 13:19 [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels Charles Keepax
2013-11-08 13:19 ` [PATCH 2/4] extcon: arizona: Fix reset of HPDET after race with removal Charles Keepax
2013-11-08 13:19 ` [PATCH 3/4] extcon: arizona: Fix race with microphone detection and removal Charles Keepax
2013-11-08 13:19 ` [PATCH 4/4] extcon: arizona: Eliminate dead error handling code Charles Keepax
2013-11-11 9:00 ` Lee Jones
2013-11-11 9:22 ` Charles Keepax [this message]
2013-11-12 0:15 ` Chanwoo Choi
2013-11-12 14:30 ` Charles Keepax
2013-11-13 2:10 ` Chanwoo Choi
2013-11-11 10:00 ` [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels Chanwoo Choi
2013-11-11 10:53 ` Lee Jones
2013-11-11 10:57 ` Chanwoo Choi
2013-11-11 11:19 ` Lee Jones
2013-11-12 0:00 ` Chanwoo Choi
2013-11-11 11:06 ` Charles Keepax
2013-11-11 11:15 ` Lee Jones
2013-11-11 11:22 ` Chanwoo Choi
2013-11-11 11:26 ` Lee Jones
2013-11-12 14:25 ` Charles Keepax
2013-11-12 15:37 ` Lee Jones
2013-11-11 11:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111092254.GC6549@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).