public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Olof Johansson <olof@lixom.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Corrupted low memory in v3.9+
Date: Mon, 11 Nov 2013 12:35:03 +0100	[thread overview]
Message-ID: <20131111113503.GA16090@gmail.com> (raw)
In-Reply-To: <527BEA91.6050603@linux.intel.com>


* H. Peter Anvin <hpa@linux.intel.com> wrote:

> On 11/07/2013 11:02 AM, Olof Johansson wrote:
> >> [    0.000000] reserving inaccessible SNB gfx pages
> >> [    0.000000] memblock_reserve: [0x00000000000000-0x00000000100000]
> 
> This is on a Sandy Bridge system, which I guess I managed to miss the 
> first time.  Unfortunately low memory corruption is expected with SNB 
> graphics... this is why we unconditionally reserve all low memory on 
> SNB.
> 
> >> setup_arch+0xa2d/0xa41
> >> [...]
> >>
> >> Unfortunately x86 doesn't keep the memblock structures around, so 
> >> there's no way to verify after booting in debugfs, but based on the 
> >> above it should have been reserved properly.
> > 
> > *prod*
> > 
> > So, got a preference on solution for this? The warning seems harmless 
> > but still annoying to get used to ignoring false positives, etc.
> > 
> > Disable the low memory checker by default? Hide it behind a debug 
> > option (runtime or build time)?
> 
> I'm inclined to say disable it by default, but I'll let Ingo comment. 
> These days we default to reserving all of low memory other than the 
> trampoline (which we really can't avoid); leaving it in as a debug 
> option seems reasonable, but it is really questionable to me how much it 
> is useful to a general user.

If we reserve everything in low memory, all the time (which I very much 
argue we should do) then the checker becomes a no-op and can be removed.

Thanks,

	Ingo

  reply	other threads:[~2013-11-11 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 18:57 Corrupted low memory in v3.9+ Olof Johansson
2013-10-17 19:39 ` H. Peter Anvin
2013-10-17 20:39   ` Olof Johansson
2013-11-07 19:02     ` Olof Johansson
2013-11-07 19:31       ` H. Peter Anvin
2013-11-11 11:35         ` Ingo Molnar [this message]
2013-11-11 23:31           ` H. Peter Anvin
2013-11-12  0:04             ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111113503.GA16090@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox