* [patch] vlynq: fix another resource size off by 1 error
@ 2013-08-23 8:19 Dan Carpenter
2013-11-11 11:48 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2013-08-23 8:19 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, kernel-janitors, Julia Lawall
We fixed the call to request_mem_region() patch
3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
But we need to fix the call the release_mem_region() as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff.
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 7b07135..c0227f9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
device_unregister(&dev->dev);
iounmap(dev->local);
- release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+ release_mem_region(dev->regs_start,
+ dev->regs_end - dev->regs_start + 1);
kfree(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] vlynq: fix another resource size off by 1 error
2013-08-23 8:19 [patch] vlynq: fix another resource size off by 1 error Dan Carpenter
@ 2013-11-11 11:48 ` Dan Carpenter
2014-01-12 19:43 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2013-11-11 11:48 UTC (permalink / raw)
To: Florian Fainelli; +Cc: linux-kernel, kernel-janitors, Julia Lawall
We still need to apply this fix.
regards,
dan carpenter
On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> We fixed the call to request_mem_region() patch
> 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> But we need to fix the call the release_mem_region() as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Static checker stuff.
>
> diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> index 7b07135..c0227f9 100644
> --- a/drivers/vlynq/vlynq.c
> +++ b/drivers/vlynq/vlynq.c
> @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
>
> device_unregister(&dev->dev);
> iounmap(dev->local);
> - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> + release_mem_region(dev->regs_start,
> + dev->regs_end - dev->regs_start + 1);
>
> kfree(dev);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] vlynq: fix another resource size off by 1 error
2013-11-11 11:48 ` Dan Carpenter
@ 2014-01-12 19:43 ` Florian Fainelli
2014-01-13 8:41 ` [patch -resend] " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2014-01-12 19:43 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors, Julia Lawall, apkm
Le lundi 11 novembre 2013, 14:48:27 Dan Carpenter a écrit :
> We still need to apply this fix.
Sorry for this late answer, vlynq changes usually go through AKPM's tree as I
don't maintain one due to the low number of changes in this code.
>
> regards,
> dan carpenter
>
> On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> > We fixed the call to request_mem_region() patch
> > 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> > But we need to fix the call the release_mem_region() as well.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff.
> >
> > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> > index 7b07135..c0227f9 100644
> > --- a/drivers/vlynq/vlynq.c
> > +++ b/drivers/vlynq/vlynq.c
> > @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
> >
> > device_unregister(&dev->dev);
> > iounmap(dev->local);
> >
> > - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> > + release_mem_region(dev->regs_start,
> > + dev->regs_end - dev->regs_start + 1);
> >
> > kfree(dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch -resend] vlynq: fix another resource size off by 1 error
2014-01-12 19:43 ` Florian Fainelli
@ 2014-01-13 8:41 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-01-13 8:41 UTC (permalink / raw)
To: Florian Fainelli, akpm; +Cc: linux-kernel, kernel-janitors, Julia Lawall
We fixed the call to request_mem_region() patch
3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
But we need to fix the call the release_mem_region() as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Resending (again) with Andrew's email corrected.
Hi, Andrew, Florian says this has to go through your tree. I assume
that means he has Acked it. :)
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 7b07135..c0227f9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
device_unregister(&dev->dev);
iounmap(dev->local);
- release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
+ release_mem_region(dev->regs_start,
+ dev->regs_end - dev->regs_start + 1);
kfree(dev);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-13 8:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 8:19 [patch] vlynq: fix another resource size off by 1 error Dan Carpenter
2013-11-11 11:48 ` Dan Carpenter
2014-01-12 19:43 ` Florian Fainelli
2014-01-13 8:41 ` [patch -resend] " Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox