public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] panic: improve panic_timeout calculation
Date: Mon, 11 Nov 2013 13:49:53 +0100	[thread overview]
Message-ID: <20131111124953.GA6765@gmail.com> (raw)
In-Reply-To: <CAMP44s0AVy=ef1k95bXsRJizW6zsPApFe9KPrRcg09ORo=2mQA@mail.gmail.com>


* Felipe Contreras <felipe.contreras@gmail.com> wrote:

> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Felipe Contreras <felipe.contreras@gmail.com> wrote:
> >
> >> We want to calculate the blinks per second, and instead of making it 5
> >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks
> >> per second.
> >
> > Please use the customary changelog style we use in the kernel:
> >
> >   " Current code does (A), this has a problem when (B).
> >     We can improve this doing (C), because (D)."
> 
> A is explained, B is empty, C is explained, D is because it makes sense.

NAKed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  reply	other threads:[~2013-11-11 12:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08  0:46 [PATCH 0/3] panic: improvements Felipe Contreras
2013-11-08  0:46 ` [PATCH 1/3] panic: setup panic_timeout early Felipe Contreras
2013-11-11 13:44   ` Ingo Molnar
2013-11-11 14:17     ` Felipe Contreras
2013-11-11 14:22       ` Ingo Molnar
2013-11-11 14:45         ` Felipe Contreras
2013-11-08  0:46 ` [PATCH 2/3] panic: improve panic_timeout calculation Felipe Contreras
2013-11-11 11:32   ` Ingo Molnar
2013-11-11 12:44     ` Felipe Contreras
2013-11-11 12:49       ` Ingo Molnar [this message]
2013-11-11 12:54         ` Felipe Contreras
2013-11-11 13:28           ` Ingo Molnar
2013-11-11 13:43             ` Felipe Contreras
2013-11-11 13:52               ` Ingo Molnar
2013-11-11 15:32                 ` Theodore Ts'o
2013-11-11 15:59                   ` Felipe Contreras
2013-11-13  0:06                     ` Ingo Molnar
2013-11-08  0:46 ` [PATCH 3/3] panic: enable local IRQs for restart timeout too Felipe Contreras
2013-11-11 13:19   ` Ingo Molnar
2013-11-11 13:30     ` Felipe Contreras
2013-11-11 13:54       ` Ingo Molnar
2013-11-11 14:40         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111124953.GA6765@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox