From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878Ab3KKNyk (ORCPT ); Mon, 11 Nov 2013 08:54:40 -0500 Received: from mail-ee0-f43.google.com ([74.125.83.43]:47755 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753387Ab3KKNyd (ORCPT ); Mon, 11 Nov 2013 08:54:33 -0500 Date: Mon, 11 Nov 2013 14:54:30 +0100 From: Ingo Molnar To: Felipe Contreras Cc: Linux Kernel Mailing List , Ingo Molnar , Linus Torvalds , Andrew Morton Subject: Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too Message-ID: <20131111135430.GC8781@gmail.com> References: <1383871600-3831-1-git-send-email-felipe.contreras@gmail.com> <1383871600-3831-4-git-send-email-felipe.contreras@gmail.com> <20131111131927.GA7258@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar wrote: > > > > * Felipe Contreras wrote: > > > >> Signed-off-by: Felipe Contreras > > > > The changelog is missing and the title is not self-explanatory. > > Either the local IRQs should be enabled for both the restart and halt > blinks, or it shouldn't be enabled for either. Why enable them for > halt, but not restart? > > I think enabling them for restart too makes sense. Such arguments belong into the changelog, with a description of what was done before and what is done after - please use the customary (verbose) changelog style we use in the kernel. Thanks, Ingo