* [PATCH try2] panic: setup panic_timeout early
@ 2013-11-11 13:39 Felipe Contreras
2013-11-11 14:16 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Felipe Contreras @ 2013-11-11 13:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Linus Torvalds, Andrew Morton, Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early
on).
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
This is exactly the same as in the previous try, but now alone since it was
mudded by largely irrelevant patches in the series.
kernel/panic.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index b6c482c..46e37ff 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -468,9 +468,21 @@ EXPORT_SYMBOL(__stack_chk_fail);
#endif
-core_param(panic, panic_timeout, int, 0644);
core_param(pause_on_oops, pause_on_oops, int, 0644);
+static int __init set_panic_timeout(char *str)
+{
+ int timeout;
+
+ if (!get_option(&str, &timeout))
+ return -EINVAL;
+
+ panic_timeout = timeout;
+ return 0;
+}
+
+early_param("panic_timeout", set_panic_timeout);
+
static int __init oops_setup(char *s)
{
if (!s)
--
1.8.4.2+fc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH try2] panic: setup panic_timeout early
2013-11-11 13:39 [PATCH try2] panic: setup panic_timeout early Felipe Contreras
@ 2013-11-11 14:16 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2013-11-11 14:16 UTC (permalink / raw)
To: Felipe Contreras; +Cc: linux-kernel, Ingo Molnar, Linus Torvalds, Andrew Morton
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> Otherwise we might not reboot when the user needs it the most (early
> on).
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> This is exactly the same as in the previous try, but now alone since it was
> mudded by largely irrelevant patches in the series.
>
> kernel/panic.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index b6c482c..46e37ff 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -468,9 +468,21 @@ EXPORT_SYMBOL(__stack_chk_fail);
>
> #endif
>
> -core_param(panic, panic_timeout, int, 0644);
> core_param(pause_on_oops, pause_on_oops, int, 0644);
>
> +static int __init set_panic_timeout(char *str)
> +{
> + int timeout;
> +
> + if (!get_option(&str, &timeout))
> + return -EINVAL;
> +
> + panic_timeout = timeout;
> + return 0;
> +}
> +
> +early_param("panic_timeout", set_panic_timeout);
> +
This still has the problem I pointed out for your v1 patch: for simple
integer parameters simple_strtol() is better and (a tiny bit) faster.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-11 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 13:39 [PATCH try2] panic: setup panic_timeout early Felipe Contreras
2013-11-11 14:16 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox