Re: [RFC/PATCHSET 00/14] perf report: Add support to accumulate hist periods (v2)

Frederic Weisbecker
2013-11-04T13:27:51Z

On Fri, Nov 01, 2013 at 03:48:37PM +0900, Namhyung Kim wrote:
> Hi Ingo,
>
> On Thu, 31 Oct 2013 09:09:32 +0100, Ingo Molnar wrote:
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> >
> >> When the -g cumulative option is given, it'll be shown like this:
> >>
> >> $ perf report -g cumulative --stdio
> >>
> >> # Overhead Overhead (Acc) Command Shared Object Symbol
> >> # ........ .............. ....... ................. .......................
> >> #
> >> 0.00% 88.29% abc libc-2.17.so [.] __libc_start_main
> >> 0.00% 88.29% abc abc [.] main
> >> 0.00% 88.29% abc abc [.] c
> >> 0.00% 88.29% abc abc [.] b
> >> 88.29% 88.29% abc abc [.] a
> >> 0.00% 11.61% abc ld-2.17.so [k] _dl_sysdep_start
> >> 0.00% 9.43% abc ld-2.17.so [.] dl_main
> >> 9.43% 9.43% abc ld-2.17.so [.] _dl_relocate_object
> >> 2.27% 2.27% abc [kernel.kallsyms] [k] page_fault
> >> 0.00% 2.18% abc ld-2.17.so [k] _dl_start_user
> >> 0.00% 0.10% abc ld-2.17.so [.] _start
> >>
> >> As you can see __libc_start_main -> main -> c -> b -> a callchain
> >> show up in the output.
> >
> > This looks really useful!
>
> Thanks! :)
>
> >
> > A couple of details:
> >
> > 1)
> >
> > This is pretty close to SysProf output, right? So why not use the
> > well-known SysProf naming and call the first column 'self' and the
> > second column 'total'? I think those names are pretty intuitive and
> > it would help people who come from SysProf over to perf.
>
> Okay, I can do it. (Although sysprof seems to call it 'cumulative'
> rather than 'total' - but I think the 'total' is better since it's
> simpler and shorter.)

OTOH cumulative probably express better what it is about. Or branch cumulative
may be.

Total is confusing because we don't know against what it is.