Re: [PATCH 14/14] perf report: Add -g cumulative option

Namhyung Kim
2013-11-05T07:45:01Z

On Fri, 1 Nov 2013 14:17:34 +0100, Jiri Olsa wrote:
> On Thu, Oct 31, 2013 at 03:56:16PM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> The -g cumulative option is for showing accumulated overhead (period)
>> value as well as self overhead.

[SNIP]

>> +static void
>> +sort_chain_cumulative(struct rb_root *rb_root __maybe_unused,
>> + struct callchain_root *chain_root __maybe_unused,
>> + u64 min_hit __maybe_unused,
>> + struct callchain_param *param __maybe_unused)
>> +{
>> +}
>
> maybe add some commentary explaning that it's intentionaly empty
>
> or maybe dont set it and do following check
> in __hists__insert_output_entry:
>
> if (symbol_conf.use_callchain && callchain_param.sort)
> callchain_param.sort(&he->sorted_chain, he->callchain,
> min_callchain_hits, &callchain_param);

Yeah, I'm fine with either way.

Hmm.. but now I think that checking existence of the sort function would
be better than having an empty function. Will change in v3.

Thanks,
Namhyung