From: Peter Zijlstra <peterz@infradead.org>
To: Mischa Jonker <Mischa.Jonker@synopsys.com>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Vineet.Gupta1@synopsys.com,
mingo@redhat.com
Subject: Re: [PATCH v3 0/2] ARC: Add perf support for ARC700 cores
Date: Mon, 11 Nov 2013 17:30:42 +0100 [thread overview]
Message-ID: <20131111163042.GA10977@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20131111162755.GC26898@twins.programming.kicks-ass.net>
On Mon, Nov 11, 2013 at 05:27:55PM +0100, Peter Zijlstra wrote:
> On Thu, Nov 07, 2013 at 02:55:10PM +0100, Mischa Jonker wrote:
> > Hi all,
> >
> > Please find v3 of my attempt to add support for perf for ARC700 PMU's. If
> > possible, it would be nice to get some feedback on the implementation from
> > non-ARC/Synopsys people familiar with the perf subsystem in Linux.
>
> Anything in particular you wanted feedback on? It looks like a fairly
> straight fwd thingy.
Ah, so its one of those that cannot sample; you might want to fail when
we try and create a sampling event.
Also, you could consider running an (hr)timer to periodically update the
events so that you don't miss a hardware counter wrap around -- if that
is a distinct possibility.
next prev parent reply other threads:[~2013-11-11 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 13:55 [PATCH v3 0/2] ARC: Add perf support for ARC700 cores Mischa Jonker
2013-11-07 13:55 ` [PATCH v3 1/2] " Mischa Jonker
2013-11-11 16:27 ` Peter Zijlstra
2013-11-12 4:36 ` Vineet Gupta
2013-11-07 13:55 ` [PATCH v3 2/2] ARC: Add documentation on DT binding for ARC700 PMU Mischa Jonker
2013-11-11 16:27 ` [PATCH v3 0/2] ARC: Add perf support for ARC700 cores Peter Zijlstra
2013-11-11 16:30 ` Peter Zijlstra [this message]
2013-11-12 9:44 ` Mischa Jonker
2013-11-12 9:15 ` Mischa Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111163042.GA10977@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Mischa.Jonker@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox