Re: N900 DT

Re: N900 DT

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Hi Pali,

On Fri, Oct 25, 2013 at 08:39:40PM +0200, Pali Rohár wrote:
> Now I found this patch and it looks like it will be in mainline 
> kernel. And after that it could be simple to listen for needed 
> events from isp driver in my bq driver (without touching isp).
> 
> https://lkml.org/lkml/2013/7/25/204
> 
> Can you look at isp1704 driver for DT support? I think that only 
> one gpio needs to be passed to driver from board data.

I had a quick overview over Jenny's patchset [0] (the patch you
referenced is part of a bigger patchset). I don't think the
scenario found in the Nokia N900 is covered by it, but probably
now is the time to change it :)

So for everybody new to this thread:

Multiple chips are involved in the charging of the Nokia N900
battery:

bq27200:   This chip is used for reading battery status. AFAIK
           it's not directly involved in charging the battery.
bq24150a:  This chip takes care of actually charging the battery.
           It has no clue about USB related stuff. The maximum
           current it draws can be configured, though.
isp1704:   USB charger detector. This chip is used to detect how
           much current may be used by the bq24150a chip.
rx51-temp: Analog temperature sensor for the battery, which is
           connected via an analog-digital-converter.

The question is how to connected these driver with each other
if device tree is used to boot the system. Any suggestions?

[0] http://thread.gmane.org/gmane.linux.kernel/1377608

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: N900 DT

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 1944 bytes --]

On Saturday 26 October 2013 02:25:02 Sebastian Reichel wrote:
> Hi Pali,
> 
> On Fri, Oct 25, 2013 at 08:39:40PM +0200, Pali Rohár wrote:
> > Now I found this patch and it looks like it will be in
> > mainline kernel. And after that it could be simple to
> > listen for needed events from isp driver in my bq driver
> > (without touching isp).
> > 
> > https://lkml.org/lkml/2013/7/25/204
> > 
> > Can you look at isp1704 driver for DT support? I think that
> > only one gpio needs to be passed to driver from board data.
> 
> I had a quick overview over Jenny's patchset [0] (the patch
> you referenced is part of a bigger patchset). I don't think
> the scenario found in the Nokia N900 is covered by it, but
> probably now is the time to change it :)
> 
> So for everybody new to this thread:
> 
> Multiple chips are involved in the charging of the Nokia N900
> battery:
> 
> bq27200:   This chip is used for reading battery status. AFAIK
>            it's not directly involved in charging the battery.
> bq24150a:  This chip takes care of actually charging the
> battery. It has no clue about USB related stuff. The maximum
> current it draws can be configured, though. isp1704:   USB
> charger detector. This chip is used to detect how much
> current may be used by the bq24150a chip. rx51-temp: Analog
> temperature sensor for the battery, which is connected via an
> analog-digital-converter.
> 
> The question is how to connected these driver with each other
> if device tree is used to boot the system. Any suggestions?
> 
> [0] http://thread.gmane.org/gmane.linux.kernel/1377608
> 
> -- Sebastian

What I need is receive property change event (from isp1704) in 
bq24150a. And with this patch https://lkml.org/lkml/2013/7/25/204 
bq24150a driver can receive them and use only these which comes 
from driver specified in DT (on n900 from isp1704).

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

RE: N900 DT

[Tc, Jenny]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2568 bytes --]


> 
> On Saturday 26 October 2013 02:25:02 Sebastian Reichel wrote:
> > Hi Pali,
> >
> > On Fri, Oct 25, 2013 at 08:39:40PM +0200, Pali Rohár wrote:
> > > Now I found this patch and it looks like it will be in mainline
> > > kernel. And after that it could be simple to listen for needed
> > > events from isp driver in my bq driver (without touching isp).
> > >
> > > https://lkml.org/lkml/2013/7/25/204
> > >
> > > Can you look at isp1704 driver for DT support? I think that only one
> > > gpio needs to be passed to driver from board data.
> >
> > I had a quick overview over Jenny's patchset [0] (the patch you
> > referenced is part of a bigger patchset). I don't think the scenario
> > found in the Nokia N900 is covered by it, but probably now is the time
> > to change it :)
> >
> > So for everybody new to this thread:
> >
> > Multiple chips are involved in the charging of the Nokia N900
> > battery:
> >
> > bq27200:   This chip is used for reading battery status. AFAIK
> >            it's not directly involved in charging the battery.
> > bq24150a:  This chip takes care of actually charging the battery. It
> > has no clue about USB related stuff. The maximum
> > current it draws can be configured, though. isp1704:   USB
> > charger detector. This chip is used to detect how much current may be
> > used by the bq24150a chip. rx51-temp: Analog temperature sensor for
> > the battery, which is connected via an analog-digital-converter.
> >
> > The question is how to connected these driver with each other if
> > device tree is used to boot the system. Any suggestions?
> >
The patch http://thread.gmane.org/gmane.linux.kernel/1377608 is intended to cover similar
scenario. It connects different components involved in charging to monitor and control the
charging.  This keeps the charging logic outside the charger driver and the charger driver just
need to be a h/w abstraction layer. It doesn't take care of the device tree part. But as long as the
drivers are registered with power supply class,  the framework can take actions. Hope this helps.

> > [0] http://thread.gmane.org/gmane.linux.kernel/1377608
> >
> > -- Sebastian
> 
> What I need is receive property change event (from isp1704) in bq24150a. And with this
> patch https://lkml.org/lkml/2013/7/25/204
> bq24150a driver can receive them and use only these which comes from driver specified in
> DT (on n900 from isp1704).
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: N900 DT

[Anton Vorontsov]

On Mon, Oct 28, 2013 at 03:01:35AM +0000, Tc, Jenny wrote:
> > On Saturday 26 October 2013 02:25:02 Sebastian Reichel wrote:
> > > On Fri, Oct 25, 2013 at 08:39:40PM +0200, Pali Rohár wrote:
> > > > Now I found this patch and it looks like it will be in mainline
> > > > kernel. And after that it could be simple to listen for needed
> > > > events from isp driver in my bq driver (without touching isp).
> > > >
> > > > https://lkml.org/lkml/2013/7/25/204
> > > >
> > > > Can you look at isp1704 driver for DT support? I think that only one
> > > > gpio needs to be passed to driver from board data.
> > >
...
> > What I need is receive property change event (from isp1704) in bq24150a. And with this
> > patch https://lkml.org/lkml/2013/7/25/204
> > bq24150a driver can receive them and use only these which comes from driver specified in
> > DT (on n900 from isp1704).

Pali, Sebastian,

I am OK with that patch. Please send it (of course preserving Jenny's
authorship), along with a user of that notifier and I'll happily apply it.

Thanks,

Anton

gitorious v3.12-rc1-n900 tree

[Pavel Machek]

Hi!

I tried pulling current linux-n900 tree from gitorious.

So far I got:

  CC      sound/soc/codecs/tpa6130a2.o
sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_i2c_read':
sound/soc/codecs/tpa6130a2.c:63:3: error: implicit declaration of
function 'i2c_smbus_read_byte_data'
[-Werror=implicit-function-declaration]
sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_i2c_write':
sound/soc/codecs/tpa6130a2.c:84:3: error: implicit declaration of
function 'i2c_smbus_write_byte_data'
[-Werror=implicit-function-declaration]
sound/soc/codecs/tpa6130a2.c: At top level:
sound/soc/codecs/tpa6130a2.c:479:1: warning: data definition has no
type or storage class [enabled by default]
sound/soc/codecs/tpa6130a2.c:479:1: warning: type defaults to 'int' in
declaration of 'module_i2c_driver' [-Wimplicit-int]
sound/soc/codecs/tpa6130a2.c:479:1: warning: parameter names (without
types) in function declaration [enabled by default]
sound/soc/codecs/tpa6130a2.c:469:26: warning: 'tpa6130a2_i2c_driver'
defined but not used [-Wunused-variable]
cc1: some warnings being treated as errors
make[3]: *** [sound/soc/codecs/tpa6130a2.o] Error 1
make[2]: *** [sound/soc/codecs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
make: *** Waiting for unfinished jobs....
  CC      drivers/media/i2c/smia/smiaregs.o
drivers/media/i2c/smia/smiaregs.c: In function 'smia_i2c_read_reg':
drivers/media/i2c/smia/smiaregs.c:518:2: error: implicit declaration
of function 'i2c_transfer' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[4]: *** [drivers/media/i2c/smia/smiaregs.o] Error 1

I'll turn off respective config options to get rid of those. Now I'm
getting

  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      init/version.o
  LD      init/built-in.o
drivers/built-in.o: In function `OMAPLFBGetLibFuncAddr':
:(.text+0x58280): undefined reference to `PVRGetDisplayClassJTable'
make: *** [vmlinux] Error 1
Command exited with non-zero status 2

...will get rid config of CONFIG_PVR next. Now it compiles...

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: gitorious v3.12-rc1-n900 tree

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 251 bytes --]

On Tuesday 05 November 2013 13:00:16 Pavel Machek wrote:
> Hi!
> 
> I tried pulling current linux-n900 tree from gitorious.

Hi, use branch v3.12-rc5-n900 (not -rc1) and consider using 
rx51_defconfig.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: gitorious v3.12-rc1-n900 tree

[Pavel Machek]

Hi!

> > I tried pulling current linux-n900 tree from gitorious.
> 
> Hi, use branch v3.12-rc5-n900 (not -rc1) and consider using 
> rx51_defconfig.

rx51_defconfig works for me, thanks.

And here are fixes for the problems I hit... please apply,

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/gpu/pvr/deviceclass.c b/drivers/gpu/pvr/deviceclass.c
index 7d64376..4a3c60c 100644
--- a/drivers/gpu/pvr/deviceclass.c
+++ b/drivers/gpu/pvr/deviceclass.c
@@ -1209,7 +1209,7 @@ void PVRSRVSetDCState(u32 ui32State)
 	}
 }
 
-static IMG_BOOL PVRGetDisplayClassJTable(
+IMG_BOOL PVRGetDisplayClassJTable(
 				struct PVRSRV_DC_DISP2SRV_KMJTABLE *psJTable)
 {
 	psJTable->ui32TableSize = sizeof(struct PVRSRV_DC_DISP2SRV_KMJTABLE);
diff --git a/drivers/media/i2c/smia/Kconfig b/drivers/media/i2c/smia/Kconfig
index 7e136e1..ed089e4 100644
--- a/drivers/media/i2c/smia/Kconfig
+++ b/drivers/media/i2c/smia/Kconfig
@@ -1,5 +1,6 @@
 config VIDEO_SMIAREGS
 	tristate "Generic SMIA I2C register access and register list helper"
+	depends on I2C
 	---help---
 	  This allows writing and reading SMIA image sensors' I2C registers
 	  easily.
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index f7c67d8..dcaf0c9 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
 
 config SND_OMAP_SOC_RX51
 	tristate "SoC Audio support for Nokia RX-51"
-	depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
+	depends on SND_OMAP_SOC && I2C && (MACH_NOKIA_RX51 || COMPILE_TEST)
 	select SND_OMAP_SOC_MCBSP
 	select SND_SOC_TLV320AIC3X
 	select SND_SOC_TPA6130A2

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: gitorious v3.12-rc1-n900 tree

[Pavel Machek]

On Wed 2013-11-06 00:12:41, Pavel Machek wrote:
> Hi!
> 
> > > I tried pulling current linux-n900 tree from gitorious.
> > 
> > Hi, use branch v3.12-rc5-n900 (not -rc1) and consider using 
> > rx51_defconfig.
> 
> rx51_defconfig works for me, thanks.
> 
> And here are fixes for the problems I hit... please apply,
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

(the patch is still needed with v3.12-rc5-n900 branch).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: gitorious v3.12-rc1-n900 tree

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 649 bytes --]

On Wednesday 06 November 2013 23:42:41 Pavel Machek wrote:
> On Wed 2013-11-06 00:12:41, Pavel Machek wrote:
> > Hi!
> > 
> > > > I tried pulling current linux-n900 tree from gitorious.
> > > 
> > > Hi, use branch v3.12-rc5-n900 (not -rc1) and consider
> > > using rx51_defconfig.
> > 
> > rx51_defconfig works for me, thanks.
> > 
> > And here are fixes for the problems I hit... please apply,
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> (the patch is still needed with v3.12-rc5-n900 branch).
> 									Pavel

Hi, thanks for patch. I commited it to v3.12-rc5-n900 branch.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]