From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Yinghai Lu <yinghai@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] x86/boot changes for v3.13
Date: Tue, 12 Nov 2013 12:23:38 +0100 [thread overview]
Message-ID: <20131112112338.GA12801@gmail.com> (raw)
In-Reply-To: <20131112103422.GA12849@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Mon, Nov 11, 2013 at 01:37:48PM -0800, Yinghai Lu wrote:
> > How do you know CPU0 and CPU1 are in same package?
>
> Why is that relevant?
So I suspect what Yinghai tried to say if CPU0 and CPU1 are not on the
same node we do the printout incorrectly.
Arguably this was a pre-existing condition, but would be nice to fix it
now that this code has emerged out of steady bitrot! :-)
How difficult would it be in your opinion? I think the best way to go
about it would be to include CPU#0 in the list - I don't think anyone will
be confused by the fact that it has already booted. That way the 'gap' for
CPU#0 would be eliminated. Or something like that.
Btw., while staring at that code once more I noticed the following small
nit, there's a pre-existing weird way of writing the -1 literal:
if (current_node > (-1))
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-12 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 17:05 [GIT PULL] x86/boot changes for v3.13 Ingo Molnar
2013-11-11 21:37 ` Yinghai Lu
2013-11-12 10:34 ` Borislav Petkov
2013-11-12 11:23 ` Ingo Molnar [this message]
2013-11-12 11:32 ` Borislav Petkov
2013-11-12 11:37 ` Ingo Molnar
2013-11-12 11:52 ` Borislav Petkov
2013-11-12 12:39 ` [PATCH] x86/smpboot: Make the code more consistent Ingo Molnar
2013-11-12 14:04 ` Borislav Petkov
2013-11-12 14:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112112338.GA12801@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).