From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: Add uprobe_task->dup_work/dup_addr
Date: Tue, 12 Nov 2013 23:13:02 +0530 [thread overview]
Message-ID: <20131112174302.GH2559@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131111165543.GA12233@redhat.com>
> Yes, and it is always equal to regs->ip when pre_ssout() is called,
>
> > and do the necessary fixups after single stepping out of line.
>
> Exactly. So it is write-only (and meaningless) to the generic uprobe
> code. We can (and perhaps should) move it into autask->saved_vaddr,
> arch_uprobe_pre_xol() can initialize it.
>
> > The casual reading of this commit message, one can get an impression
> > that vaddr is never needed.
>
> See above. The changelog doesn't say we can simply remove it, it says
> "move it".
Okay, moving to arch_uprobe_task is fine. I probably got confused by
"First of all it is not really needed,"
>
> > Your change still retains it.
>
>
> OK. How about dup_xol_work/dup_xol_vaddr ?
>
Yes fine with me.
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2013-11-12 17:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 19:00 [PATCH] uprobes: Add uprobe_task->dup_work/dup_addr Oleg Nesterov
2013-11-10 15:43 ` Masami Hiramatsu
2013-11-10 17:28 ` Oleg Nesterov
2013-11-11 1:37 ` Masami Hiramatsu
2013-11-11 1:43 ` Masami Hiramatsu
2013-11-11 7:11 ` Srikar Dronamraju
2013-11-11 16:55 ` Oleg Nesterov
2013-11-11 17:59 ` Oleg Nesterov
2013-11-12 17:43 ` Srikar Dronamraju [this message]
2013-11-12 19:20 ` [PATCH v2] " Oleg Nesterov
2013-11-13 5:22 ` Srikar Dronamraju
2013-11-24 8:19 ` Masami Hiramatsu
2013-11-25 12:10 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112174302.GH2559@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).