From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data
Date: Tue, 12 Nov 2013 21:31:14 +0000 [thread overview]
Message-ID: <20131112213114.GB14439@danjae> (raw)
In-Reply-To: <20131112121508.GE4053@ghostprotocols.net>
On Tue, Nov 12, 2013 at 09:15:08AM -0300, Arnaldo Carvalho de Melo wrote:
> Second part, just rewrote the changelog a bit:
>
> commit 4e8a6e566fc611b9cbec2978a52266f29cb65785
> Author: Namhyung Kim <namhyung.kim@lge.com>
> Date: Tue Nov 12 15:25:00 2013 +0900
>
> perf trace: Fix segfault on perf trace -i perf.data
>
> When replaying a previous record session, it'll get a segfault since it
> doesn't initialize raw_syscalls enter/exit tracepoint's evsel->priv for
> caching the format fields.
>
> So fix it by properly initializing sys_enter/exit evsels that comes from
> reading the perf.data file header.
Looks good to me!
Thanks for doing this, Arnaldo. I'll try to avoid this kind of thing
again in the future.
Thanks,
Namhyung
next prev parent reply other threads:[~2013-11-12 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 6:24 [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as fd Namhyung Kim
2013-11-12 6:25 ` [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data Namhyung Kim
2013-11-12 11:46 ` Arnaldo Carvalho de Melo
2013-11-12 11:57 ` Arnaldo Carvalho de Melo
2013-11-12 12:15 ` Arnaldo Carvalho de Melo
2013-11-12 21:31 ` Namhyung Kim [this message]
2013-11-12 21:27 ` Namhyung Kim
2013-11-12 13:23 ` Arnaldo Carvalho de Melo
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Separate tp syscall field caching into init routine to be reused tip-bot for Namhyung Kim
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Fix segfault on perf trace -i perf.data tip-bot for Namhyung Kim
2013-11-12 15:50 ` [PATCH 1/2] perf trace: Beautify fifth argument of mmap() as fd David Ahern
2013-11-12 21:56 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112213114.GB14439@danjae \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).