From: Ingo Molnar <mingo@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf trace: Simplify '--summary' output
Date: Tue, 12 Nov 2013 22:33:34 +0100 [thread overview]
Message-ID: <20131112213334.GF25913@gmail.com> (raw)
In-Reply-To: <1384267334-18953-1-git-send-email-penberg@kernel.org>
* Pekka Enberg <penberg@kernel.org> wrote:
> The output of 'perf trace --summary' tries to be too cute with
> formatting and makes it very hard to read. Simplify it in the spirit of
> "strace -c":
>
> [penberg@localhost libtrading]$ perf trace -a --duration 10000 --summary -- sleep 1
> ^C
Btw., just a very small feature suggestion - instead of forcing the
somewhat counter-intuitive '-- sleep X' pattern it might be helpful to
have a general option parser for 'delay' values, which would allow a wide
range of time units like:
--delay 10.5h
--delay 0.1s
--delay 0.1sec
etc. - with the default unit being 'seconds'.
That parser could then be applied to '--duration' filter as well, allowing
things like:
--duration 10sec
which IMHO are more obvious to read (and easier to remember!) than
'--duration 10000'.
> Summary of events:
>
> dbus-daemon (555), 10 events, 0.0%, 0.000 msec
>
> msec/call
> syscall calls min avg max stddev
> --------------- -------- -------- -------- -------- ------
> sendmsg 2 0.002 0.005 0.008 55.00
> recvmsg 2 0.002 0.003 0.005 44.00
> epoll_wait 1 0.000 0.000 0.000 0.00
In what units is stddev? Percentage? If yes then it might be useful to
output it as %. [and probably to restrict precision to a single digit,
standard deviations are rarely more accurate than 0.1%.]
> NetworkManager (667), 56 events, 0.0%, 0.000 msec
>
> msec/call
> syscall calls min avg max stddev
> --------------- -------- -------- -------- -------- ------
> poll 2 0.000 0.002 0.003 100.00
> sendmsg 10 0.004 0.007 0.016 15.41
> recvmsg 16 0.002 0.003 0.005 8.24
>
> zfs-fuse (669), 4 events, 0.0%, 0.000 msec
>
> msec/call
> syscall calls min avg max stddev
> --------------- -------- -------- -------- -------- ------
> futex 2 0.000 0.001 0.002 100.00
Nice looking output btw! :-)
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-12 21:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 14:42 [PATCH] perf trace: Simplify '--summary' output Pekka Enberg
2013-11-12 21:33 ` Ingo Molnar [this message]
2013-11-12 21:36 ` David Ahern
2013-11-12 21:38 ` Pekka Enberg
2013-11-12 21:42 ` David Ahern
2013-11-12 21:50 ` Ingo Molnar
2013-11-12 21:40 ` Ingo Molnar
2013-11-13 6:57 ` Pekka Enberg
2013-11-13 11:14 ` Ingo Molnar
2013-11-12 21:56 ` [tip:perf/urgent] " tip-bot for Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112213334.GF25913@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).