From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel@vger.kernel.org, "David Ahern" <dsahern@gmail.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Jiri Olsa" <jolsa@redhat.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: perf top -u <uid> does not seem to be working
Date: Wed, 13 Nov 2013 00:26:09 +0100 [thread overview]
Message-ID: <20131112232609.GA31474@gmail.com> (raw)
In-Reply-To: <20131112232249.GA31384@gmail.com>
an unrelated bug is a missing newline if the 'uid' is invalid:
hubble:~> perf top --stdio -u help
Error:
Invalid User: helphubble:~>
Fixed by the patch below.
comet:~/tip/tools/perf> perf top --stdio -u help
Error:
Invalid User: help
comet:~/tip/tools/perf>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
tools/perf/builtin-top.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b8f8e29..71e6402 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1172,7 +1172,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
status = target__validate(target);
if (status) {
target__strerror(target, status, errbuf, BUFSIZ);
- ui__warning("%s", errbuf);
+ ui__warning("%s\n", errbuf);
}
status = target__parse_uid(target);
@@ -1180,7 +1180,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
int saved_errno = errno;
target__strerror(target, status, errbuf, BUFSIZ);
- ui__error("%s", errbuf);
+ ui__error("%s\n", errbuf);
status = -saved_errno;
goto out_delete_evlist;
next prev parent reply other threads:[~2013-11-12 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 23:22 perf top -u <uid> does not seem to be working Ingo Molnar
2013-11-12 23:26 ` Ingo Molnar [this message]
2013-11-15 7:24 ` [tip:perf/urgent] perf top: Add missing newline if the 'uid' is invalid tip-bot for Ingo Molnar
2013-11-13 17:59 ` perf top -u <uid> does not seem to be working Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112232609.GA31474@gmail.com \
--to=mingo@kernel.org \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).