From: Ingo Molnar <mingo@kernel.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] panic: improve panic_timeout calculation
Date: Wed, 13 Nov 2013 01:06:33 +0100 [thread overview]
Message-ID: <20131113000633.GB2420@gmail.com> (raw)
In-Reply-To: <CAMP44s0qsjc_hHedYGt9tB=v8_UArM4N+vnwNybZ39vaoRXytA@mail.gmail.com>
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Mon, Nov 11, 2013 at 9:32 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> > On Mon, Nov 11, 2013 at 02:52:16PM +0100, Ingo Molnar wrote:
> >> > That's exactly what I did. Addressing feedback constructively doesn't
> >> > mean do exactly what you say without arguing.
> >>
> >> Your reply to my routine feedback was obtuse, argumentative and needlessly
> >> confrontative - that's not 'constructive'.
> >
> > Felipe, remember when on the Git list Junio said he would stop trying
> > to respond to any patches that had problems because you couldn't
> > respond constructively to feedback, and you claimed that you had no
> > problems working with other folks, including on the Linux Kernel
> > mailing list?
>
> Ingo Molnar != kernel folks, and I don't see any hints of kernel folks
> suggesting to drop patch #1 because of non-technical issues.
>
> If the patch is technically correct, conforms to standard practices, and
> solves a problem; it gets applied. Isn't that how it works in Linux?
I simply described to you what is standing Linux kernel maintenance
policy.
It is not new nor unusual that kernel patch changelog quality matters:
defective changelogs are routinely pointed out during review and are
required to be fixed before a patch can progress. Linux kernel maintainers
frequently push back against deficient changelogs - in fact they are
expected to push back against them.
Your claim that a changelog defect that got pointed out during review is a
'non-technical', 'administrative' problem in Linux kernel development is
simply wrong and your continued stubborn refusal to address such review
feedback constructively is unnecessarily complicating the efficient
processing of these patches.
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-13 0:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 0:46 [PATCH 0/3] panic: improvements Felipe Contreras
2013-11-08 0:46 ` [PATCH 1/3] panic: setup panic_timeout early Felipe Contreras
2013-11-11 13:44 ` Ingo Molnar
2013-11-11 14:17 ` Felipe Contreras
2013-11-11 14:22 ` Ingo Molnar
2013-11-11 14:45 ` Felipe Contreras
2013-11-08 0:46 ` [PATCH 2/3] panic: improve panic_timeout calculation Felipe Contreras
2013-11-11 11:32 ` Ingo Molnar
2013-11-11 12:44 ` Felipe Contreras
2013-11-11 12:49 ` Ingo Molnar
2013-11-11 12:54 ` Felipe Contreras
2013-11-11 13:28 ` Ingo Molnar
2013-11-11 13:43 ` Felipe Contreras
2013-11-11 13:52 ` Ingo Molnar
2013-11-11 15:32 ` Theodore Ts'o
2013-11-11 15:59 ` Felipe Contreras
2013-11-13 0:06 ` Ingo Molnar [this message]
2013-11-08 0:46 ` [PATCH 3/3] panic: enable local IRQs for restart timeout too Felipe Contreras
2013-11-11 13:19 ` Ingo Molnar
2013-11-11 13:30 ` Felipe Contreras
2013-11-11 13:54 ` Ingo Molnar
2013-11-11 14:40 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113000633.GB2420@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox