linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Christian Ruppert <christian.ruppert@abilis.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Uncompressed kernel doesn't build on x86_64
Date: Wed, 13 Nov 2013 11:34:18 -0500	[thread overview]
Message-ID: <20131113113418.167b8ffd@IRBT4585> (raw)

Hi Christian,

Your recent patch enables uncompressed kernels, but selecting that
option (CONFIG_KERNEL_UNCOMPRESSED) fails on x86_86:

commit 69f0554ec261fd686ac7fa1c598cc9eb27b83a80
Author: Christian Ruppert <christian.ruppert@abilis.com>
Date:   Tue Nov 12 15:11:43 2013 -0800

    init/Kconfig: add option to disable kernel compression

That's how it fails:

  LD      init/built-in.o
  KSYM    .tmp_kallsyms1.o
  KSYM    .tmp_kallsyms2.o
  LD      vmlinux
  SORTEX  vmlinux
  SYSMAP  System.map
  VOFFSET arch/x86/boot/voffset.h
make[4]: *** No rule to make target
  `arch/x86/boot/compressed/vmlinux.bin.', needed by
  `arch/x86/boot/compressed/piggy.S'.  Stop. make[3]: ***
  [arch/x86/boot/compressed/vmlinux] Error 2 make[2]: *** [bzImage]
  Error 2 make[1]: *** [sub-make] Error 2 make: *** [all] Error 2

arch/x86/boot/compressed/Makefile has no provision for uncompressed
files.  There is no definition for suffix-$(CONFIG_KERNEL_UNCOMPRESSED)
so $(suffix-y) evaluates to an empty string and there is no rule to
make vmlinuz.bin.$(suffix-y)

I think the patch should be either reverted or fixed as soon as
possible.

Any suggestions for uncompressed suffix?  I'd go with "copy".  Then the
"compression" could be a symlink.  Alternatively, the "." could be
included in other suffixes, the uncompressed suffix would be empty and
the compression would be an empty statement.

-- 
Regards,
Pavel Roskin

             reply	other threads:[~2013-11-13 16:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 16:34 Pavel Roskin [this message]
2013-11-13 16:49 ` Uncompressed kernel doesn't build on x86_64 H. Peter Anvin
2013-11-14  8:32 ` Christian Ruppert
2013-11-14  8:38   ` [PATCH 1/2] init/Kconfig: add option to disable kernel compression Christian Ruppert
2013-11-14 10:21     ` Vineet Gupta
2013-11-15 16:57       ` Christian Ruppert
2013-11-16  9:41         ` Vineet Gupta
2013-11-14  8:38   ` [PATCH 2/2] x86: Add support for uncompressed kernel images Christian Ruppert
2013-11-14 17:31     ` H. Peter Anvin
2013-11-15  9:31       ` Christian Ruppert
2013-11-14 17:45     ` H. Peter Anvin
2013-11-15  9:49       ` Christian Ruppert
2013-11-15 10:06         ` H. Peter Anvin
2013-11-14 14:13   ` Uncompressed kernel doesn't build on x86_64 Austin S Hemmelgarn
2013-11-14 23:38     ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113113418.167b8ffd@IRBT4585 \
    --to=proski@gnu.org \
    --cc=akpm@linux-foundation.org \
    --cc=christian.ruppert@abilis.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).