linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf trace: Tweak summary output
Date: Wed, 13 Nov 2013 13:57:34 +0100	[thread overview]
Message-ID: <20131113125734.GA22140@gmail.com> (raw)
In-Reply-To: <1384345308-24404-1-git-send-email-penberg@kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

> Tweak the summary output as suggested by Ingo Molnar:
> 
>   [penberg@localhost ~]$ perf trace -a --duration 10000 --summary -- sleep 1
>   ^C
>    Summary of events:
> 
>    Xorg (817), 148 events, 0.0%, 0.000 msec
> 
>      syscall            calls      min       avg       max      stddev
>                                  (msec)    (msec)    (msec)        (%)
>      --------------- -------- --------- --------- ---------     ------
>      read                   7     0.002     0.004     0.011     32.00%
>      rt_sigprocmask        40     0.001     0.001     0.002      1.31%
>      ioctl                  6     0.002     0.003     0.005     19.45%
>      writev                 7     0.004     0.018     0.059     43.76%
>      select                 9     0.000    74.513   507.869     74.61%
>      setitimer              4     0.001     0.002     0.002     10.08%

Acked-by: Ingo Molnar <mingo@kernel.org>

Are you convinced about double-digit precision output for percentages?

I think it suggest a false level of accuracy, but YYMV - typographically 
xx.yy certainly looks nicer than xx.y (it's more symmetric).

Thanks,

	Ingo

  reply	other threads:[~2013-11-13 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 12:21 [PATCH] perf trace: Tweak summary output Pekka Enberg
2013-11-13 12:57 ` Ingo Molnar [this message]
2013-11-13 13:25   ` Pekka Enberg
2013-11-13 13:31     ` Ingo Molnar
2013-11-15  7:24 ` [tip:perf/urgent] " tip-bot for Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113125734.GA22140@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).