From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Laight <David.Laight@ACULAB.COM>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] sched: Check TASK_DEAD rather than EXIT_DEAD in schedule_debug()
Date: Wed, 13 Nov 2013 16:45:16 +0100 [thread overview]
Message-ID: <20131113154516.GA15810@redhat.com> (raw)
In-Reply-To: <20131113144856.GL26898@twins.programming.kicks-ass.net>
On 11/13, Peter Zijlstra wrote:
>
> On Wed, Nov 13, 2013 at 03:35:52PM +0100, Oleg Nesterov wrote:
> >
> > As for "nobody should use exit_state". I'll try to recheck, but iirc
> > we already discussed this... do you remember any reason why
> > schedule_debug() can't check prev->state == TASK_DEAD instead of
> > ->exit_state?
>
> I have no such memories :/ but a quick test shows that such a kernel
> does boot without issue.
probably my memory fools me. OK, it seems that you agree with this change,
hopefully we both can't be wrong ;)
> Acked-by: Peter Zijlstra <peterz@infradead.org>
Thanks! And since picked this series, perhaps you can also queue this
one?
Oleg.
next prev parent reply other threads:[~2013-11-13 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 14:35 [PATCH 0/3] state/exit_state cleanups (Was: Remove unused variable ret from sync_thread_master()) Oleg Nesterov
2013-11-13 14:36 ` [PATCH 1/3] proc: cleanup/simplify get_task_state/task_state_array Oleg Nesterov
2013-11-13 14:36 ` [PATCH 2/3] fork: no need to initialize child->exit_state Oleg Nesterov
2013-11-27 14:10 ` [tip:sched/core] tasks/fork: Remove unnecessary child->exit_state tip-bot for Oleg Nesterov
2013-11-13 14:36 ` [PATCH 3/3] exit_state: kill task_is_dead() Oleg Nesterov
2013-11-27 14:10 ` [tip:sched/core] tasks/exit: Remove unused task_is_dead() method tip-bot for Oleg Nesterov
2013-11-13 14:48 ` [PATCH 0/3] state/exit_state cleanups (Was: Remove unused variable ret from sync_thread_master()) Peter Zijlstra
2013-11-13 14:50 ` Peter Zijlstra
2013-11-13 15:45 ` Oleg Nesterov [this message]
2013-11-13 15:45 ` [PATCH 1/1] sched: Check TASK_DEAD rather than EXIT_DEAD in schedule_debug() Oleg Nesterov
2013-11-27 14:10 ` [tip:sched/core] " tip-bot for Oleg Nesterov
2013-11-13 15:58 ` [PATCH 0/1] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113154516.GA15810@redhat.com \
--to=oleg@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox