From: Ingo Molnar <mingo@kernel.org>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>, David Ahern <dsahern@gmail.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [BUG] perf stat: explicit grouping yields unexpected results
Date: Fri, 15 Nov 2013 07:34:57 +0100 [thread overview]
Message-ID: <20131115063457.GB12442@gmail.com> (raw)
In-Reply-To: <CABPqkBTiBHF4wZ3c_Czkh3JgvXGNWJW1LH42Jh4NG_ZJkGkbgw@mail.gmail.com>
* Stephane Eranian <eranian@google.com> wrote:
> Jiri,
>
> I was trying the grouping support in perf stat and I was surprised
> to see that if I create a group that is too big to be scheduled, and
> where only N out of P events can fit, perf stat still yields counts
> for the N events. I was expecting 0 counts or <not supported>.
>
> The kernel semantic is to schedule all the events in a group or
> none. Perf does something different and this is confusing. If you
> use explicit grouping then I think you want to group to fail if not
> all the events can be scheduled:
>
> On an IvyBridge:
> $ perf stat --g -e
> '{cycles,instructions,branches,branches,branches,branches,branches}'
> noploop 1
> 3 229 417 079 cycles
> 3 223 919 023 instructions # 1,00 insns per cycle
> 3 220 868 098 branches
> 3 220 868 098 branches
> 3 220 868 098 branches
> 3 220 868 098 branches
> <not supported> branches
>
> I think it should be: <not supported> for all events.
Btw., does the kernel side currently support discovery of such
impossible group scheduling constraints at group setup time? If not
then it probably should and it should reject them straight away.
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-15 6:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 20:50 [BUG] perf stat: explicit grouping yields unexpected results Stephane Eranian
2013-11-15 6:34 ` Ingo Molnar [this message]
2013-11-15 9:24 ` Stephane Eranian
2013-11-15 10:34 ` Ingo Molnar
2013-11-15 10:41 ` Stephane Eranian
2013-11-15 10:50 ` Peter Zijlstra
2013-11-15 11:52 ` Peter Zijlstra
2013-11-15 11:58 ` Stephane Eranian
2013-11-17 3:41 ` Andi Kleen
2013-11-29 13:33 ` Jiri Olsa
2013-11-29 13:43 ` Stephane Eranian
2013-11-29 13:52 ` Jiri Olsa
2013-11-29 14:01 ` Stephane Eranian
2013-12-02 15:23 ` Andi Kleen
2013-12-03 2:52 ` Stephane Eranian
2013-12-03 23:44 ` Andi Kleen
2013-11-15 10:05 ` Peter Zijlstra
2013-11-15 10:13 ` Stephane Eranian
2013-11-15 10:49 ` Peter Zijlstra
2013-11-15 15:08 ` Vince Weaver
2013-11-15 22:52 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115063457.GB12442@gmail.com \
--to=mingo@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox