From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758009Ab3KOJ5p (ORCPT ); Fri, 15 Nov 2013 04:57:45 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33205 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494Ab3KOJ5k (ORCPT ); Fri, 15 Nov 2013 04:57:40 -0500 Date: Fri, 15 Nov 2013 09:57:31 +0000 From: Mel Gorman To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, dave.jiang@intel.com, akpm@linux-foundation.org, dhillf@gmail.com, Naoya Horiguchi Subject: Re: [PATCH 1/2] mm: hugetlbfs: Add some VM_BUG_ON()s to catch non-hugetlbfs pages Message-ID: <20131115095731.GC26002@suse.de> References: <20131114233357.90EE35C1@viggo.jf.intel.com> <20131114233358.2B10EA33@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20131114233358.2B10EA33@viggo.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2013 at 03:33:58PM -0800, Dave Hansen wrote: > > From: Dave Hansen > > Dave Jiang reported that he was seeing oopses when running > NUMA systems and default_hugepagesz=1G. I traced the issue down > to migrate_page_copy() trying to use the same code for hugetlb > pages and transparent hugepages. It should not have been trying > to pass thp pages in there. > > So, add some VM_BUG_ON()s for the next hapless VM developer that > tries the same thing. > > Signed-off-by: Dave Hansen > Reviewed-by: Naoya Horiguchi > Acked-by: Mel Gorman -- Mel Gorman SUSE Labs