public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	"mingo@elte.hu" <mingo@elte.hu>, David Ahern <dsahern@gmail.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [BUG] perf stat: explicit grouping yields unexpected results
Date: Fri, 15 Nov 2013 11:49:28 +0100	[thread overview]
Message-ID: <20131115104928.GA10456@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBRO=LNwHbRWKE_NnR5TUTh3sjTyp-9BOkvxQGKb2f3k7A@mail.gmail.com>

On Fri, Nov 15, 2013 at 11:13:27AM +0100, Stephane Eranian wrote:
> On Fri, Nov 15, 2013 at 11:05 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Fri, Nov 15, 2013 at 07:34:57AM +0100, Ingo Molnar wrote:
> >> Btw., does the kernel side currently support discovery of such
> >> impossible group scheduling constraints at group setup time?
> >
> > Up to a point.
> >
> It is only looking at the group itself  not the overall condition
> of the system, e.g., the other HT thread is case of shared
> resources.
> I think all it guarantees is that if the events in the group
> are compatible with each other. And I think it covers the case
> where the events use different counters but the same shared
> resource, e.g., offcore_response on Intel X86.
> 
> >> If not
> >> then it probably should and it should reject them straight away.
> >
> > We do I think, for the case where its obvious it can never fit.
> >
> > That said, if you have a pinned cpu event, it all comes apart.
> 
> You mean in the group?

No, outside of the group, so that the above validation doesn't guarantee
actual schedulability. Yes it could all fit on the PMU in one go, but
since we _have_ to also fit this pinned task, it really will never get
scheduled.



  reply	other threads:[~2013-11-15 10:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 20:50 [BUG] perf stat: explicit grouping yields unexpected results Stephane Eranian
2013-11-15  6:34 ` Ingo Molnar
2013-11-15  9:24   ` Stephane Eranian
2013-11-15 10:34     ` Ingo Molnar
2013-11-15 10:41       ` Stephane Eranian
2013-11-15 10:50       ` Peter Zijlstra
2013-11-15 11:52       ` Peter Zijlstra
2013-11-15 11:58         ` Stephane Eranian
2013-11-17  3:41       ` Andi Kleen
2013-11-29 13:33         ` Jiri Olsa
2013-11-29 13:43           ` Stephane Eranian
2013-11-29 13:52             ` Jiri Olsa
2013-11-29 14:01               ` Stephane Eranian
2013-12-02 15:23           ` Andi Kleen
2013-12-03  2:52             ` Stephane Eranian
2013-12-03 23:44               ` Andi Kleen
2013-11-15 10:05   ` Peter Zijlstra
2013-11-15 10:13     ` Stephane Eranian
2013-11-15 10:49       ` Peter Zijlstra [this message]
2013-11-15 15:08   ` Vince Weaver
2013-11-15 22:52     ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115104928.GA10456@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox