From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: linux-kernel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
gregkh@linuxfoundation.org, oleg@redhat.com,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 0/6] list: introduce list_last_entry_or_null()
Date: Fri, 15 Nov 2013 06:11:00 -0800 [thread overview]
Message-ID: <20131115141100.GA17659@infradead.org> (raw)
In-Reply-To: <5285A33C.4040808@oracle.com>
On Fri, Nov 15, 2013 at 12:29:48PM +0800, Jeff Liu wrote:
> Hi Folks,
>
> This patch is trying to introduce a new list helper to retrieve the
> last entry or return NULL if the list is empty corresponding to it,
> which is inspired by Jiri Pirko's list_first_entry_or_null().
How did we end up with the stupid _or_null prefix there? I think the
functionality is useful, but the naming is way to verbose, especially
given that a list_first_entry or list_last_entry that optimizes away
that one check doesn't seem useful.
Instead of encoding detailed semantics in the name a good kerneldoc
comment is way better.
next prev parent reply other threads:[~2013-11-15 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 4:29 [PATCH 0/6] list: introduce list_last_entry_or_null() Jeff Liu
2013-11-15 14:11 ` Christoph Hellwig [this message]
2013-11-15 14:26 ` [Cluster-devel] " Steven Whitehouse
2013-11-15 16:00 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115141100.GA17659@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.liu@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=oleg@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).