From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Shuah Khan <shuah.kh@samsung.com>,
len.brown@intel.com, pavel@ucw.cz, rjw@rjwysocki.net,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com
Subject: Re: [PATCH] power: Replace printks with pr_* routines
Date: Sat, 16 Nov 2013 07:10:57 +0900 [thread overview]
Message-ID: <20131115221057.GA16530@kroah.com> (raw)
In-Reply-To: <1384551981.18739.36.camel@joe-AO722>
On Fri, Nov 15, 2013 at 01:46:21PM -0800, Joe Perches wrote:
> On Sat, 2013-11-16 at 06:19 +0900, Greg KH wrote:
> > On Fri, Nov 15, 2013 at 09:10:06AM -0700, Shuah Khan wrote:
> > > Replaced printks with pr_* routines. dev_* routines could have been used,
> > > but chose to use pr_* to avoid breaking scripts that might be relying on
> > > a specific text.
> >
> > I'd really like to switch to dev_* instead, even changing to pr_* should
> > change the output prefix (if it's set for this file, odds are it isn't
> > though...)
>
> It's not.
>
> Something like this?
>
> Pass a struct device * through to the PM
> suspend logging routines. Use dev_<level>
> instead of printks.
That looks good to me, Shuah, does it work for you?
greg k-h
next prev parent reply other threads:[~2013-11-15 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 16:10 [PATCH] power: Replace printks with pr_* routines Shuah Khan
2013-11-15 21:19 ` Greg KH
2013-11-15 21:46 ` Joe Perches
2013-11-15 22:10 ` Greg KH [this message]
2013-11-15 22:27 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115221057.GA16530@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox