From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Ashley Lai <adlai@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
Peter Huewe <peterhuewe@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c
Date: Sat, 16 Nov 2013 17:12:36 -0700 [thread overview]
Message-ID: <20131117001236.GA22861@obsidianresearch.com> (raw)
In-Reply-To: <1384640335.7518.12.camel@fishsauce>
On Sat, Nov 16, 2013 at 04:18:55PM -0600, Ashley Lai wrote:
> Nice clean up!!! The code looks much more clean after removing the
> duplicated code in all drivers. Thanks.
> > +++ b/drivers/char/tpm/tpm-dev.c
> > + * Copyright (C) 2013 Obsidian Reearch Corp
>
> Typo Research?
Yes, thanks :)
> > + * Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > + *
>
> > +
> > +int tpm_dev_add_device(struct tpm_chip *chip)
> > +{
>
> > + rc = misc_register(&chip->vendor.miscdev);
> > + if (rc) {
> > + chip->vendor.miscdev.name = NULL;
> > + dev_warn(chip->dev,
>
> Any reason why we use dev_warn here instead of dev_err?
Indeed, it was dev_err before I moved it.
Hmm, it has been so long.. I think an earlier draft had
tpm_dev_add_device return void (like in other subsystems), so warn
made more sense. However I eventually changed it to propogate errors,
and didn't catch the flip.
Lets put it back.
Thanks!
Jason
next prev parent reply other threads:[~2013-11-17 0:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 3:38 tpm: Remainder of earlier clean up Jason Gunthorpe
2013-11-04 3:38 ` [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c Jason Gunthorpe
2013-11-16 22:18 ` [tpmdd-devel] " Ashley Lai
2013-11-17 0:12 ` Jason Gunthorpe [this message]
2013-11-04 3:38 ` [PATCH 2/5 v2] tpm: Pull everything related to sysfs into tpm-sysfs.c Jason Gunthorpe
2013-11-16 23:53 ` [tpmdd-devel] " Ashley Lai
2013-11-17 0:24 ` Jason Gunthorpe
2013-11-04 3:38 ` [PATCH 3/5 v2] tpm: Create a tpm_class_ops structure and use it in the drivers Jason Gunthorpe
2013-11-17 0:57 ` [tpmdd-devel] " Ashley Lai
2013-11-04 3:38 ` [PATCH 4/5 v2] tpm: Use the ops structure instead of a copy in tpm_vendor_specific Jason Gunthorpe
2013-11-17 1:09 ` [tpmdd-devel] " Ashley Lai
2013-11-04 3:38 ` [PATCH 5/5 v2] tpm: Make tpm-dev allocate a per-file structure Jason Gunthorpe
2013-11-17 2:01 ` [tpmdd-devel] " Ashley Lai
2013-11-08 16:54 ` [tpmdd-devel] tpm: Remainder of earlier clean up Ashley Lai
2013-11-08 17:23 ` Aw: " Peter Huewe
2013-12-07 13:21 ` Peter Hüwe
2013-12-10 1:33 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131117001236.GA22861@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=adlai@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox