From: Wolfram Sang <wsa@the-dreams.de>
To: Andreas Werner <wernerandy@gmx.de>
Cc: jacmet@sunsite.dk, khali@linux-fr.org, dianders@chromium.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received
Date: Sun, 17 Nov 2013 19:31:03 +0100 [thread overview]
Message-ID: <20131117183103.GC8577@katana> (raw)
In-Reply-To: <1384710380-5976-1-git-send-email-wernerandy@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Sun, Nov 17, 2013 at 06:46:20PM +0100, Andreas Werner wrote:
> Using the i2c-eg20t driver and call i2cdetect or probe on the bus,
> the driver will print a lot of error messages if there was no ACK
> received.
>
> i2cdetect normally print a table with all the available devices. If there
> is no device on the address, the table will be empty.
> Currently with the i2c-eg20t driver, the table is not visible because
> the error messages destroy the table.
>
> Error message: pch_i2c_getack return -71
>
> This patch prevent the driver to print the messages to syslog.
> The pch_i2c_wait_for_check_xfer function is the only one who is
> calling pch_i2c_getack, so we can delete the function and add the
> read to pch_i2c_wait_for_check_xfer.
> If no ACK is received, the Message will be printed as a dbg
> message.
>
> Fixed print message to be a one liner so we can grep for the
> error message.
>
> Tested on Intel Atom E6xx and Eg20t Chipset.
>
> Signed-off-by: Andreas Werner <wernerandy@gmx.de>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-11-17 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 17:46 [PATCH v3] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received Andreas Werner
2013-11-17 18:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131117183103.GC8577@katana \
--to=wsa@the-dreams.de \
--cc=dianders@chromium.org \
--cc=jacmet@sunsite.dk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wernerandy@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).