From: Dave Young <dyoung@redhat.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de
Subject: Re: [patch 3/7 v2] Cleanup efi_enter_virtual_mode function
Date: Mon, 18 Nov 2013 10:08:51 +0800 [thread overview]
Message-ID: <20131118020850.GA4025@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <1384557682.1791.9.camel@misato.fc.hp.com>
On 11/15/13 at 04:21pm, Toshi Kani wrote:
> On Tue, 2013-11-05 at 16:20 +0800, dyoung@redhat.com wrote:
> > Add two small functions:
> > efi_merge_regions and efi_map_regions, efi_enter_virtual_mode
> > calls them instead of embedding two long for loop.
>
> :
>
> > +void __init efi_enter_virtual_mode(void)
> > +{
> > + efi_status_t status;
> > + void *p, *new_memmap = NULL;
>
> *p is unused.
The *p was removed in later patch, will remove it in this patch.
Thanks for review.
Dave
next prev parent reply other threads:[~2013-11-18 2:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 8:20 [patch 0/7 v2] kexec kernel efi runtime support dyoung
2013-11-05 8:20 ` [patch 1/7 v2] Add function efi_remap_region for remapping to saved virt address dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:38 ` Dave Young
2013-11-15 23:02 ` Toshi Kani
2013-11-18 2:09 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-05 8:20 ` [patch 2/7 v2] x86 efi: reserve boot service fix dyoung
2013-11-15 23:10 ` Toshi Kani
2013-11-05 8:20 ` [patch 3/7 v2] Cleanup efi_enter_virtual_mode function dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:39 ` Dave Young
2013-11-15 23:21 ` Toshi Kani
2013-11-18 2:08 ` Dave Young [this message]
2013-11-05 8:20 ` [patch 4/7 v2] export more efi table variable to sysfs dyoung
2013-11-12 0:40 ` Greg KH
2013-11-12 8:19 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:31 ` Greg KH
2013-11-05 8:20 ` [patch 5/7 v2] export efi runtime memory mapping " dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:50 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-19 12:18 ` Matt Fleming
2013-11-05 8:20 ` [patch 6/7 v2] passing kexec necessary efi data via setup_data dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:52 ` Dave Young
2013-11-05 8:20 ` [patch 7/7 v2] x86: add xloadflags bit for efi runtime support on kexec dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:53 ` Dave Young
2013-11-13 16:20 ` H. Peter Anvin
2013-11-14 1:36 ` Dave Young
2013-11-05 14:40 ` [patch 0/7 v2] kexec kernel efi runtime support Borislav Petkov
2013-11-08 14:31 ` Matt Fleming
2013-11-09 3:57 ` Dave Young
2013-11-09 5:01 ` H. Peter Anvin
2013-11-11 2:13 ` Dave Young
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:47 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118020850.GA4025@dhcp-16-126.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).