From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [patch] perf/trace properly use u64 to hold event_id
Date: Mon, 18 Nov 2013 09:53:35 +0100 [thread overview]
Message-ID: <20131118085335.GC3866@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1311151236100.11932@vincent-weaver-1.um.maine.edu>
On Fri, Nov 15, 2013 at 12:39:45PM -0500, Vince Weaver wrote:
>
> The 64-bit attr.config value for perf trace events was being copied into
> an "int" before doing a comparison, meaning the top 32 bits were
> being truncated.
>
> As far as I can tell this didn't cause any errors, but it did mean
> it was possible to create valid aliases for all the tracepoint ids
> which I don't think was intended. (For example, 0xffffffff00000018
> and 0x18 both enable the same tracepoint).
>
> Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Thanks!
next prev parent reply other threads:[~2013-11-18 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 17:39 [patch] perf/trace properly use u64 to hold event_id Vince Weaver
2013-11-18 8:53 ` Peter Zijlstra [this message]
2013-11-19 19:19 ` [tip:perf/urgent] perf/trace: Properly " tip-bot for Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118085335.GC3866@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox