From: Sascha Hauer <s.hauer@pengutronix.de>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Dave Airlie <airlied@gmail.com>,
devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3
Date: Mon, 18 Nov 2013 10:03:10 +0100 [thread overview]
Message-ID: <20131118090309.GU24559@pengutronix.de> (raw)
In-Reply-To: <20131112171544.GR20328@hansolo.jdub.homelinux.org>
On Tue, Nov 12, 2013 at 12:15:45PM -0500, Josh Boyer wrote:
> commit b8d181e408af (staging: drm/imx: add drm plane support) added a file
> to the make target for DRM_IMX_IPUV3 but didn't adjust the objs required
> to actually build that as a module. Kbuild got confused and this lead to
> link errors like:
>
> ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
> ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
>
> Additionally, it added a call to imx_drm_crtc_id which also fails with a
> link error as above. To fix this, we adjust the make target with the proper
> objs, which will change the name of the resulting .ko. We also add an
> EXPORT_SYMBOL_GPL for imx_drm_crtc_id.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/staging/imx-drm/Makefile | 4 +++-
> drivers/staging/imx-drm/imx-drm-core.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/Makefile b/drivers/staging/imx-drm/Makefile
> index 2c3a9e1..8742432 100644
> --- a/drivers/staging/imx-drm/Makefile
> +++ b/drivers/staging/imx-drm/Makefile
> @@ -8,4 +8,6 @@ obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
> obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
> obj-$(CONFIG_DRM_IMX_FB_HELPER) += imx-fbdev.o
> obj-$(CONFIG_DRM_IMX_IPUV3_CORE) += ipu-v3/
> -obj-$(CONFIG_DRM_IMX_IPUV3) += ipuv3-crtc.o ipuv3-plane.o
> +
> +imx-ipuv3-crtc-objs := ipuv3-crtc.o ipuv3-plane.o
> +obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crtc.o
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index 4483d47..2b366d8 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -72,6 +72,7 @@ int imx_drm_crtc_id(struct imx_drm_crtc *crtc)
> {
> return crtc->pipe;
> }
> +EXPORT_SYMBOL_GPL(imx_drm_crtc_id);
>
> static void imx_drm_driver_lastclose(struct drm_device *drm)
> {
> --
> 1.8.3.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-11-18 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:15 [PATCH] staging: imx-drm: Fix modular build of DRM_IMX_IPUV3 Josh Boyer
2013-11-18 9:03 ` Sascha Hauer [this message]
2013-11-20 1:56 ` Josh Boyer
2013-11-20 5:39 ` Greg KH
2013-11-20 13:16 ` Josh Boyer
2013-11-20 16:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118090309.GU24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=airlied@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).