From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf top: Make -g refer to callchains
Date: Mon, 18 Nov 2013 09:59:45 -0300 [thread overview]
Message-ID: <20131118125945.GA3669@ghostprotocols.net> (raw)
In-Reply-To: <20131115054609.GB4514@gmail.com>
Em Fri, Nov 15, 2013 at 06:46:09AM +0100, Ingo Molnar escreveu:
> btw., here's some 'perf top' call graph performance and profiling
> quality feedback, with the latest perf code:
>
> 'perf top --call-graph fp' now works very well, using just 0.2%
> of CPU time on a fast system:
>
> 4676 mingo 20 0 612m 56m 9948 S 1 0.2 0:00.68 perf
>
> 'perf top --call-graph dwarf' on the other hand is horrendously
> slow, using 20% of CPU time on a 4 GHz CPU:
>
> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
> 4646 mingo 20 0 658m 81m 12m R 19 0.3 0:18.17 perf
>
> On another system with a 2.4GHz CPU it's taking up 100% of CPU
> time (!):
>
> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
> 8018 mingo 20 0 290320 45220 8520 R 99.5 0.3 0:58.81 perf
>
> Profiling 'perf top' shows all sorts of very high dwarf
> processing overhead:
Yeah, top dwarf callchain has been so far a proof of concept, it
exacerbates problems that can be seen on 'report', but since its live,
we can see it more clearly.
The work on improving callchain processing, (rb_tree'ing, new comm
infrastructure) alleviated the problem a bit.
Tuning the stack size requested from the kernel and using --max-stack
can help when it is really needed, but yes, work on it is *badly* needed.
- Arnaldo
next prev parent reply other threads:[~2013-11-18 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 3:51 [PATCH] perf top: Make -g refer to callchains David Ahern
2013-11-15 5:28 ` Ingo Molnar
2013-11-15 5:46 ` Ingo Molnar
2013-11-18 12:59 ` Arnaldo Carvalho de Melo [this message]
2013-11-18 13:25 ` Jiri Olsa
2013-11-18 14:26 ` Ingo Molnar
2013-11-18 17:49 ` Jiri Olsa
2013-11-18 19:17 ` Ingo Molnar
2013-11-18 20:16 ` Jan Kratochvil
2013-11-19 9:26 ` Jean Pihet
2013-11-19 9:33 ` Jan Kratochvil
2013-11-19 9:24 ` Jean Pihet
2013-11-30 12:49 ` [tip:perf/core] " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118125945.GA3669@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).