From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752036Ab3KRM75 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Nov 2013 07:59:57 -0500
Received: from mail-yh0-f50.google.com ([209.85.213.50]:52530 "EHLO
	mail-yh0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751297Ab3KRM7w (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Nov 2013 07:59:52 -0500
Date: Mon, 18 Nov 2013 09:59:45 -0300
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>, linux-kernel@vger.kernel.org,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf top: Make -g refer to callchains
Message-ID: <20131118125945.GA3669@ghostprotocols.net>
References: <1384487490-6865-1-git-send-email-dsahern@gmail.com>
 <20131115054609.GB4514@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131115054609.GB4514@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Nov 15, 2013 at 06:46:09AM +0100, Ingo Molnar escreveu:
> btw., here's some 'perf top' call graph performance and profiling 
> quality feedback, with the latest perf code:
> 
> 'perf top --call-graph fp' now works very well, using just 0.2% 
> of CPU time on a fast system:
> 
>  4676 mingo     20   0  612m  56m 9948 S     1  0.2   0:00.68 perf                                                                                                        
> 
> 'perf top --call-graph dwarf' on the other hand is horrendously 
> slow, using 20% of CPU time on a 4 GHz CPU:
> 
>   PID USER      PR  NI  VIRT  RES  SHR S  %CPU %MEM    TIME+  COMMAND                                                                                                     
>  4646 mingo     20   0  658m  81m  12m R    19  0.3   0:18.17 perf    
> 
> On another system with a 2.4GHz CPU it's taking up 100% of CPU 
> time (!):
> 
>   PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND                                                                                               
>  8018 mingo     20   0  290320  45220   8520 R  99.5  0.3   0:58.81 perf      
> 
> Profiling 'perf top' shows all sorts of very high dwarf 
> processing overhead:

Yeah, top dwarf callchain has been so far a proof of concept, it
exacerbates problems that can be seen on 'report', but since its live,
we can see it more clearly.

The work on improving callchain processing, (rb_tree'ing, new comm
infrastructure) alleviated the problem a bit.

Tuning the stack size requested from the kernel and using --max-stack
can help when it is really needed, but yes, work on it is *badly* needed.

- Arnaldo