From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Clement Chauplannaz <chauplac@gmail.com>
Cc: linux-kbuild@vger.kernel.org, mmarek@suse.cz,
sedat.dilek@gmail.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/config: allow setting a string which value contains a colon
Date: Mon, 18 Nov 2013 19:06:19 +0100 [thread overview]
Message-ID: <20131118180619.GA3458@free.fr> (raw)
In-Reply-To: <1384689334-6979-1-git-send-email-chauplac@gmail.com>
Clément, All,
On 2013-11-17 12:55 +0100, Clement Chauplannaz spake thusly:
> A bug in script `config' prevented from modifying an existing variable's
> value to a string that contains a colon ':'. The reason behind it is that
> colons are used as a separator in `sed' commands that script `config'
> relies on.
>
> Escape colons in `sed' commands to allow values containing colons.
>
> Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
It'll be in my tree soon, as a rc-fix. Thank you.
Regards,
Yann E. MORIN.
> ---
> scripts/config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/config b/scripts/config
> index 6804179..4b16260 100755
> --- a/scripts/config
> +++ b/scripts/config
> @@ -78,7 +78,7 @@ txt_append() {
>
> txt_subst() {
> local before="$1"
> - local after="$2"
> + local after="${2//:/\:}"
> local infile="$3"
> local tmpfile="$infile.swp"
>
> --
> 1.8.3.2.dirty
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2013-11-18 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 11:55 [PATCH] scripts/config: allow setting a string which value contains a colon Clement Chauplannaz
2013-11-18 18:06 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118180619.GA3458@free.fr \
--to=yann.morin.1998@free.fr \
--cc=chauplac@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).