From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646Ab3KSHPg (ORCPT ); Tue, 19 Nov 2013 02:15:36 -0500 Received: from mail-ea0-f173.google.com ([209.85.215.173]:39511 "EHLO mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784Ab3KSHPe (ORCPT ); Tue, 19 Nov 2013 02:15:34 -0500 Date: Tue, 19 Nov 2013 08:15:31 +0100 From: Ingo Molnar To: Andrew Morton Cc: Jason Baron , benh@kernel.crashing.org, paulus@samba.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, Felipe Contreras Subject: Re: [PATCH v2] panic: Make panic_timeout configurable Message-ID: <20131119071531.GA32469@gmail.com> References: <20131118210436.233B5202A@prod-mail-relay06.akamai.com> <20131118143059.afe17d2faced16171a05eb10@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131118143059.afe17d2faced16171a05eb10@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andrew Morton wrote: > On Mon, 18 Nov 2013 21:04:36 +0000 (GMT) Jason Baron wrote: > > > The panic_timeout value can be set via the command line option 'panic=x', or via > > /proc/sys/kernel/panic, however that is not sufficient when the panic occurs > > before we are able to set up these values. Thus, add a CONFIG_PANIC_TIMEOUT > > so that we can set the desired value from the .config. > > > > The default panic_timeout value continues to be 0 - wait forever, except for > > powerpc and mips, which have been defaulted to 180 and 5 respectively. This > > is in keeping with the fact that these arches already set panic_timeout in > > their arch init code. However, I found three exceptions- two in mips and one in > > powerpc where the settings didn't match these default values. In those cases, I > > left the arch code so it continues to override, in case the user has not changed > > from the default. It would nice if these arches had one default value, or if we > > could determine the correct setting at compile-time. > > Felipe is proposing a simpler patch ("panic: setup panic_timeout > early") which switches to early_param(). Is that sufficient for the > (undescribed!) failure which you are presumably observing? Also note that that patch is still incomplete: if panic_timeout is switched to early_param() then closely related functionality such as pause_on_oops should be moved early as well... Thanks, Ingo