From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"Johannes Löthberg" <johannes@kyriasis.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: boot: Fix mixed indentation in a20.c
Date: Tue, 19 Nov 2013 11:34:08 +0100 [thread overview]
Message-ID: <20131119103408.GA3640@pd.tnic> (raw)
In-Reply-To: <20131119072241.GB32478@gmail.com>
On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
>
> * H. Peter Anvin <hpa@zytor.com> wrote:
>
> > On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > > Replace all mixed indentation with tabs
> > >
> > > Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
> >
> > NAK. Not worth the churn in the absence of other changes.
>
> Yes.
>
> If a20.c was cleaned up altogether, that might be a more tempting
> change, it has a good number of inconsistencies and improving it all
> would make it more readable.
>
> But it makes little sense to do an incomplete cleanup.
Yeah, senseless cleanup without any benefit whatsoever (yeah, fuck
readability! :-)) should be forbidden, if you ask me. Especially
since it dilutes and muds up git history and finding the patch which
introduced a change turns into a serious undertaking.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-11-19 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 17:50 [PATCH] x86: boot: Fix mixed indentation in a20.c Johannes Löthberg
2013-11-19 2:22 ` H. Peter Anvin
2013-11-19 7:22 ` Ingo Molnar
2013-11-19 10:34 ` Borislav Petkov [this message]
2013-11-19 17:48 ` Joe Perches
2013-11-19 18:23 ` Borislav Petkov
2013-11-19 18:24 ` H. Peter Anvin
2013-11-19 18:28 ` Joe Perches
2013-11-19 18:45 ` H. Peter Anvin
2013-11-19 18:59 ` Borislav Petkov
2013-11-25 10:18 ` Ingo Molnar
2013-11-25 11:02 ` Borislav Petkov
2013-11-26 0:51 ` Joe Perches
2013-11-26 7:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119103408.GA3640@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=johannes@kyriasis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).