From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
voice.shen@atmel.com, sboyd@codeaurora.org,
akpm@linux-foundation.org, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision
Date: Tue, 19 Nov 2013 18:42:48 +0000 [thread overview]
Message-ID: <20131119184248.GA27599@flint.arm.linux.org.uk> (raw)
In-Reply-To: <tip-ce5dae03973461e2a42098c53d62946b98baab42@git.kernel.org>
On Tue, Nov 19, 2013 at 10:12:23AM -0800, tip-bot for Stephen Boyd wrote:
> + /*
> + * Use 4MHz instead of 1MHz so that things like 1.832Mhz show as
> + * 1832Khz
How about getting proper SI units.
Hertz is Hz - that's capital H and lower case z. It's also the surname
of an engineer.
Kilo is always lower case k. Therefore, the unit of 1000 cycles per
second is kHz and not KHZ, khz, Khz, khZ or any other stupid mixture
of cases.
Given that we are programmers, and programming computers requires an
attention to detail, completely ignoring such detail when it comes to
SI units is extremely poor - and suggests that we are illerate.
May I suggest more care is taken in the future?
--
Russell King
ARM architecture Linux Kernel maintainer
next parent reply other threads:[~2013-11-19 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-ce5dae03973461e2a42098c53d62946b98baab42@git.kernel.org>
2013-11-19 18:42 ` Russell King [this message]
2013-11-19 19:12 ` [tip:sched/urgent] sched_clock: Document 4Mhz vs 1Mhz decision Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119184248.GA27599@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox