From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482Ab3KSW7H (ORCPT ); Tue, 19 Nov 2013 17:59:07 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42360 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753026Ab3KSW7D (ORCPT ); Tue, 19 Nov 2013 17:59:03 -0500 Date: Tue, 19 Nov 2013 14:59:17 -0800 From: Greg KH To: Shuah Khan Cc: Joe Perches , len.brown@intel.com, pavel@ucw.cz, rjw@rjwysocki.net, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, shuahkhan@gmail.com Subject: Re: [PATCH v2] power: Replace printks with dev_* and pr_* routines Message-ID: <20131119225917.GA12930@kroah.com> References: <1384886818-11861-1-git-send-email-shuah.kh@samsung.com> <1384887205.17783.40.camel@joe-AO722> <528BB492.8090404@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <528BB492.8090404@samsung.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2013 at 11:57:22AM -0700, Shuah Khan wrote: > On 11/19/2013 11:53 AM, Joe Perches wrote: > > On Tue, 2013-11-19 at 11:46 -0700, Shuah Khan wrote: > >> Replaced printks with dev_* and pr_* routines. Replacing printk in > >> __suspend_report_result() will require passing in struct device * > >> pointer from calling routines and this will require changes to > >> external interface suspend_report_result() which is used by several > >> drivers. Hence, this one instance is replaced by pr_err(). > > [] > >> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > > [] > >> @@ -1308,9 +1308,8 @@ int dpm_prepare(pm_message_t state) > >> error = 0; > >> continue; > >> } > >> - printk(KERN_INFO "PM: Device %s not prepared " > >> - "for power transition: code %d\n", > >> - dev_name(dev), error); > >> + dev_info("PM: not prepared for power transition: ", > >> + "code %d\n", error); > > > > Shuah, you have to make sure the files modified by > > your patches compile successfully before sending > > patches like this. > > > > > > Oops. I did compile. Missed the warning. Sorry about that. It should be an "error"... It adds a codingstyle warning as well, so fix that up for the next version please :) greg k-h