The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: ZHAO Gang <gamerh2o@gmail.com>
Cc: Mark Einon <mark.einon@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] staging: et131x: clean up code
Date: Tue, 19 Nov 2013 21:41:19 -0800	[thread overview]
Message-ID: <20131120054119.GC367@kroah.com> (raw)
In-Reply-To: <CAAb+SYbnL7bNd6+yibrp+bYRKCM+kC_X+kg+KUsZtGj2S0JaaA@mail.gmail.com>

On Wed, Nov 20, 2013 at 09:53:36AM +0800, ZHAO Gang wrote:
> > I'm a bit confused - these patches apply to the current head of
> > staging-next, but not on top of your previous two patches. I assume that
> > you're aiming to have these changes on top of your last two, so can you
> > please re-spin them to apply cleanly to the head of (staging-next + your
> > previous patches)?
> 
> Hi, please revert the previous two patches if you can. This four
> patches include previous changes, just more descriptive.
> 
> I think previous patches' style may be not so good, and it had
> received no response when I sent this patch set, so I just dropped
> them and redid the work :-)

In the future, you need to tell me to drop the old ones from my queue.
Normally you can do that by replying to them saying to remove them, or
put a "v2" for "version 2" on this series.

Anyway, as Mark told you to redo them a bit, care to do a "v3" series
with his recommended changes (i.e. the TODO file update)?

thanks,

greg k-h

  parent reply	other threads:[~2013-11-20  5:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 12:27 [PATCH 1/4] staging: et131x: clean up code ZHAO Gang
2013-11-15 12:29 ` [PATCH 2/4] staging: et131x: drop packet when error occurs in et131x_tx ZHAO Gang
2013-11-15 12:31 ` [PATCH 3/4] staging: et131x: stop read when hit max delay in et131x_phy_mii_read ZHAO Gang
2013-11-15 12:31 ` [PATCH 4/4] staging: et131x: remove spinlock adapter->lock ZHAO Gang
2013-11-18 21:54 ` [PATCH 1/4] staging: et131x: clean up code Mark Einon
2013-11-20  1:53   ` ZHAO Gang
2013-11-20  4:24     ` ZHAO Gang
2013-11-20  5:41     ` Greg Kroah-Hartman [this message]
2013-11-20  7:34       ` ZHAO Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131120054119.GC367@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gamerh2o@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.einon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox