public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long
Date: Wed, 20 Nov 2013 13:48:00 +0100	[thread overview]
Message-ID: <20131120124758.GA308@localhost.localdomain> (raw)
In-Reply-To: <20131119192145.GA8604@redhat.com>

On Tue, Nov 19, 2013 at 08:21:45PM +0100, Oleg Nesterov wrote:
> DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the unwanted
> bits in the "unsigned long" data, but "ulong &= ~int" also clears the
> upper bits that are not specified in mask.
> 
> This is actually fine, dr6[32:63] are reserved, but this is not clear
> so it would be better to make them "unsigned long" to cleanup the code.
> 
> However, depending on sizeof(long), DR6_RESERVED should be either
> 0xFFFF0FF0 or 0xFFFFFFFF_FFFF0FF0, so this patch redefines them as
> (~ 32_bit_mask UL) to avoid ifdef's.
> 
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Suggested-by: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Ok, I'm queuing it just to make sure it's not forgotten.

Thanks.

      parent reply	other threads:[~2013-11-20 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 19:21 [PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long Oleg Nesterov
2013-11-19 19:22 ` Oleg Nesterov
2013-11-20 12:48 ` Frederic Weisbecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131120124758.GA308@localhost.localdomain \
    --to=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox