* [PATCH 1/1] ASoC: arizona: Set FLL to free-run before disabling
@ 2013-11-20 13:15 Richard Fitzgerald
2013-11-20 13:36 ` Mark Brown
2013-11-20 14:37 ` [PATCH v2 " Richard Fitzgerald
0 siblings, 2 replies; 4+ messages in thread
From: Richard Fitzgerald @ 2013-11-20 13:15 UTC (permalink / raw)
To: broonie; +Cc: lgirdwood, perex, tiwai, ckeepax, patches, alsa-devel,
linux-kernel
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
sound/soc/codecs/arizona.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index 6f05b17..fea9910 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -1529,6 +1529,8 @@ static void arizona_enable_fll(struct arizona_fll *fll,
try_wait_for_completion(&fll->ok);
regmap_update_bits(arizona->regmap, fll->base + 1,
+ ARIZONA_FLL1_FREERUN, 0);
+ regmap_update_bits(arizona->regmap, fll->base + 1,
ARIZONA_FLL1_ENA, ARIZONA_FLL1_ENA);
if (use_sync)
regmap_update_bits(arizona->regmap, fll->base + 0x11,
@@ -1546,6 +1548,8 @@ static void arizona_disable_fll(struct arizona_fll *fll)
struct arizona *arizona = fll->arizona;
bool change;
+ regmap_update_bits(arizona->regmap, fll->base + 1,
+ ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
regmap_update_bits_check(arizona->regmap, fll->base + 1,
ARIZONA_FLL1_ENA, 0, &change);
regmap_update_bits(arizona->regmap, fll->base + 0x11,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ASoC: arizona: Set FLL to free-run before disabling
2013-11-20 13:15 [PATCH 1/1] ASoC: arizona: Set FLL to free-run before disabling Richard Fitzgerald
@ 2013-11-20 13:36 ` Mark Brown
2013-11-20 14:37 ` [PATCH v2 " Richard Fitzgerald
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-11-20 13:36 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: lgirdwood, perex, tiwai, ckeepax, patches, alsa-devel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
On Wed, Nov 20, 2013 at 01:15:47PM +0000, Richard Fitzgerald wrote:
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Why? Is this a bug fix or a feature?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] ASoC: arizona: Set FLL to free-run before disabling
2013-11-20 13:15 [PATCH 1/1] ASoC: arizona: Set FLL to free-run before disabling Richard Fitzgerald
2013-11-20 13:36 ` Mark Brown
@ 2013-11-20 14:37 ` Richard Fitzgerald
2013-11-20 15:20 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Richard Fitzgerald @ 2013-11-20 14:37 UTC (permalink / raw)
To: broonie; +Cc: alsa-devel, tiwai, linux-kernel, patches, lgirdwood, perex
The FLL must be placed into free-run mode before disabling
to allow it to entirely shut down.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
sound/soc/codecs/arizona.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index 6f05b17..fea9910 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -1529,6 +1529,8 @@ static void arizona_enable_fll(struct arizona_fll *fll,
try_wait_for_completion(&fll->ok);
regmap_update_bits(arizona->regmap, fll->base + 1,
+ ARIZONA_FLL1_FREERUN, 0);
+ regmap_update_bits(arizona->regmap, fll->base + 1,
ARIZONA_FLL1_ENA, ARIZONA_FLL1_ENA);
if (use_sync)
regmap_update_bits(arizona->regmap, fll->base + 0x11,
@@ -1546,6 +1548,8 @@ static void arizona_disable_fll(struct arizona_fll *fll)
struct arizona *arizona = fll->arizona;
bool change;
+ regmap_update_bits(arizona->regmap, fll->base + 1,
+ ARIZONA_FLL1_FREERUN, ARIZONA_FLL1_FREERUN);
regmap_update_bits_check(arizona->regmap, fll->base + 1,
ARIZONA_FLL1_ENA, 0, &change);
regmap_update_bits(arizona->regmap, fll->base + 0x11,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] ASoC: arizona: Set FLL to free-run before disabling
2013-11-20 14:37 ` [PATCH v2 " Richard Fitzgerald
@ 2013-11-20 15:20 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2013-11-20 15:20 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: alsa-devel, tiwai, linux-kernel, patches, lgirdwood, perex
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
On Wed, Nov 20, 2013 at 02:37:09PM +0000, Richard Fitzgerald wrote:
> The FLL must be placed into free-run mode before disabling
> to allow it to entirely shut down.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-20 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20 13:15 [PATCH 1/1] ASoC: arizona: Set FLL to free-run before disabling Richard Fitzgerald
2013-11-20 13:36 ` Mark Brown
2013-11-20 14:37 ` [PATCH v2 " Richard Fitzgerald
2013-11-20 15:20 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox