The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH -v2 09/10] mfd: staging: Constify struct mfd_cell where possible
Date: Thu, 21 Nov 2013 11:02:11 +0000	[thread overview]
Message-ID: <20131121110211.GB23067@lee--X1> (raw)
In-Reply-To: <1384781586-4798-9-git-send-email-geert@linux-m68k.org>

On Mon, 18 Nov 2013, Geert Uytterhoeven wrote:

> As of commit 03e361b25ee8dfb1fd9b890072c23c4aae01c6c7 ("mfd: Stop setting
> refcounting pointers in original mfd_cell arrays"), the "cell" parameter of
> mfd_add_devices() is "const" again. Hence make all cell data passed to
> mfd_add_devices() const where possible.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: devel@driverdev.osuosl.org
> ---
> v2: Split in groups
> 
>  drivers/staging/nvec/nvec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It looks like I need Greg's Ack on this before I apply it.

> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 3066ee2e753b..27d74134f187 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -83,7 +83,7 @@ enum nvec_sleep_subcmds {
>  
>  static struct nvec_chip *nvec_power_handle;
>  
> -static struct mfd_cell nvec_devices[] = {
> +static const struct mfd_cell nvec_devices[] = {
>  	{
>  		.name = "nvec-kbd",
>  		.id = 1,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2013-11-21 11:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 13:32 [PATCH -v2 01/10] mfd: dialog: Constify struct mfd_cell where possible Geert Uytterhoeven
2013-11-18 13:32 ` [PATCH -v2 02/10] mfd: intel: " Geert Uytterhoeven
2013-11-18 13:32 ` [PATCH -v2 03/10] mfd: marvell: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 04/10] mfd: maxim: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 05/10] mfd: stmicro: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 06/10] mfd: ti: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 07/10] mfd: toshiba: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 08/10] mfd: wolfson: " Geert Uytterhoeven
2013-11-18 13:33 ` [PATCH -v2 09/10] mfd: staging: " Geert Uytterhoeven
2013-11-21 11:02   ` Lee Jones [this message]
2013-11-21 15:16     ` Greg Kroah-Hartman
2013-11-18 13:33 ` [PATCH -v2 10/10] mfd: " Geert Uytterhoeven
2013-11-18 14:29 ` [PATCH -v2 01/10] mfd: dialog: " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121110211.GB23067@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox