public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Robert Richter <rric@kernel.org>
Subject: Re: [PATCH] perf: Move fs.* to generic lib/lk/
Date: Thu, 21 Nov 2013 12:42:24 +0100	[thread overview]
Message-ID: <20131121114224.GA27704@gmail.com> (raw)
In-Reply-To: <20131121113014.GA26009@pd.tnic>


* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Nov 21, 2013 at 12:17:44PM +0100, Ingo Molnar wrote:
> > > However, now that I think of it, the naming is kinda imprecise 
> > > having only "kernel" in it - it only denotes that it is a library of 
> > > stuff that has grown in the kernel.
> > > 
> > > So how about
> > > 
> > > tools/lib/ktools/
> > > tools/lib/kutils/
> > > tools/lib/kernel-tools/
> > > tools/lib/kernel-utils/
> > > ...
> > > 
> > > and
> > > 
> > > libktools.so
> > > libkutils.so
> > > ...
> > > 
> > > ?
> > > 
> > > I'd prefer ktools as in the tools/ directory of the kernel repo.
> > 
> > So what does each name mean, what would they be used for and what's 
> > the difference between them?
> 
> Oh no, I'm only proposing multiple libraries but multiple names to 
> choose *only* *one* from them - the one which we think fits best.
> 
> Basically I wanna say: "this is the library of tools which grew in 
> the tools/ directory of the kernel repo".
> 
> Thus I'm proposing
> 
> 	tools/lib/ktools/
> 
> as a path and
> 
> 	libktools.so
> 
> as a library name, because, IMHO, this name is closer to the reality.
>
> tools/lib/kernel/ is also ok - it does not describe the collection 
> of functionality that precisely, IMHO, that's all.
> 
> Am I even making sense here?

Ok - so why not call it tools/lib/kernel/ or tools/lib/kernelapi/ or 
tools/lib/kapi/?

That's really what is common about it: it offers various helper 
methods to interface with the Linux kernel: debugfs, procfs, sysfs 
handling routines with no policy, just pure, obvious helpers to use 
kernel functionality.

[ Naming it 'ktools' is not optimal because these are already tools/ 
  ... the secondary meaning of 'tools' in that context is easily lost. 
  Same goes for 'kutils', the secondary meaning is confusing (to me). ]

... and just in case you are wondering why I'm making a fuss about it: 
a naming discussion for something fundamental as this isn't bikeshed 
painting, we really want people to look at that place to readily stuff 
kernel related helpers into, and the name should make that very 
obvious.

Thanks,

	Ingo

  reply	other threads:[~2013-11-21 11:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 21:56 [PATCH] perf: Move fs.* to generic lib/lk/ Borislav Petkov
2013-11-21  7:34 ` Ingo Molnar
2013-11-21 10:07   ` Borislav Petkov
2013-11-21 11:17     ` Ingo Molnar
2013-11-21 11:30       ` Borislav Petkov
2013-11-21 11:42         ` Ingo Molnar [this message]
2013-11-21 12:06           ` Borislav Petkov
2013-11-21 12:39             ` Steven Rostedt
2013-11-21 13:49               ` Borislav Petkov
2013-11-21 13:56                 ` Steven Rostedt
2013-11-21 14:18                   ` Borislav Petkov
2013-11-21 15:12               ` Arnaldo Carvalho de Melo
2013-11-21 15:05             ` Arnaldo Carvalho de Melo
2013-11-21 15:28               ` Borislav Petkov
2013-11-21 17:37                 ` Arnaldo Carvalho de Melo
2013-11-21 19:00                   ` Borislav Petkov
2013-11-22 12:27                   ` Ingo Molnar
2013-11-22 13:50                     ` Borislav Petkov
2013-11-22 15:00                       ` Arnaldo Carvalho de Melo
2013-11-22 15:20                         ` David Ahern
2013-11-22 15:39                       ` Ingo Molnar
2013-11-22 15:54                         ` Ingo Molnar
2013-11-23 13:12                           ` Borislav Petkov
2013-11-26 18:03                             ` Ingo Molnar
2013-11-27 15:42                               ` Borislav Petkov
2013-11-23 13:04                         ` Borislav Petkov
2013-11-26 18:17                           ` Ingo Molnar
2013-11-27 15:39                             ` Borislav Petkov
2013-11-28 12:16                               ` Borislav Petkov
2013-12-02 20:30                                 ` Arnaldo Carvalho de Melo
2013-11-22 14:57                     ` Arnaldo Carvalho de Melo
2013-11-22 15:43                       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131121114224.GA27704@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@infradead.org \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rric@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox