Re: [PATCH] perf: Move fs.* to generic lib/lk/

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Thu, Nov 21, 2013 at 04:28:04PM +0100, Borislav Petkov escreveu:
> On Thu, Nov 21, 2013 at 12:05:24PM -0300, Arnaldo Carvalho de Melo wrote:
> > "To offers various helper methods to interface with the Linux kernel:
> >  debugfs, procfs, sysfs handling routines with no policy, just pure,
> >  obvious helpers to use kernel functionality."
 
> Exactly.
 
> > Naming is a bit hard, to keep it small, descriptive, as API can lead
> > people to think about other kinds of kernel APIs (syscalls?), "fskapi"
> > to mean "fs based kernel API" would perhaps be more descriptive? A
> > longer (more descriptive) possibility would be "linux-fskapi".
 
> Yeah, you can't have fskapi because we'll add other stuff to it (see
> the diffstat I sent you last week) so not filesystem stuff only. So I
> think "kapi" is as generic and as fitting as it gets. We can use the
> "kernel-api" variant but I think the "k" is enough.

I think is that it is too generic, the other stuff you mention is not
really "kapi" at all.

The rest, things like util.c, usage.c, rbtree.c, hash, strlist, etc are
all, well, utilities that we got from the kernel, from git, or that were
created for perf, could get a tools/lib/util/ generic name and be
outside the one with the description agreed above.

But they are not "helper methods to interface with the Linux kernel" at
all.

If "libc" is the "library that comes with the C language" we could have
liblk for the "library that came from the Linux kernel".

But "libkapi" seems the wrong name for a library with those utilities :-\

- Arnaldo