From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755390Ab3KUTIj (ORCPT ); Thu, 21 Nov 2013 14:08:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754980Ab3KUTIh (ORCPT ); Thu, 21 Nov 2013 14:08:37 -0500 Date: Thu, 21 Nov 2013 14:08:08 -0500 From: Vivek Goyal To: Greg KH Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, hpa@zytor.com, mjg59@srcf.ucam.org Subject: Re: [PATCH 1/6] kexec: Export vmcoreinfo note size properly Message-ID: <20131121190808.GJ16208@redhat.com> References: <1384969851-7251-1-git-send-email-vgoyal@redhat.com> <1384969851-7251-2-git-send-email-vgoyal@redhat.com> <20131121185900.GB17070@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131121185900.GB17070@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2013 at 10:59:00AM -0800, Greg KH wrote: > On Wed, Nov 20, 2013 at 12:50:46PM -0500, Vivek Goyal wrote: > > Right now we seem to be exporting the max data size contained inside > > vmcoreinfo note. But this does not include the size of meta data around > > vmcore info data. Like name of the note and starting and ending elf_note. > > > > I think user space expects total size and that size is put in PT_NOTE > > elf header. > > > > Signed-off-by: Vivek Goyal > > --- > > kernel/ksysfs.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > This should go into 3.13, right? > > Nice fix. Yes. This is just a general fix for kexec. I noticed it while going through the code. Thanks Vivek